Closed Bug 120188 Opened 23 years ago Closed 22 years ago

"Save as file" dialog produces an error when you click cancel

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: neil, Assigned: sspitzer)

References

Details

Attachments

(1 file, 4 obsolete files)

final patch
10.13 KB, patch
Details | Diff | Splinter Review 
In mail and news select an email.  Go to File->Save As->File.  It brings up the
file picker dialog box.  Now hit cancel.  It brings up a dialog box which says
"Unable to save message. Please check your file name and try again later."

It just seems kind of pointless, afterall I was the one who told it to cancel.
*** Bug 120657 has been marked as a duplicate of this bug. ***
*** Bug 145066 has been marked as a duplicate of this bug. ***
change qa contact to myself
QA Contact: esther → sheelar
*** Bug 139357 has been marked as a duplicate of this bug. ***
*** Bug 151522 has been marked as a duplicate of this bug. ***
Summary: "Save as file" dialog produces a dialog when you click cancel → "Save as file" dialog produces an error when you click cancel
*** Bug 157971 has been marked as a duplicate of this bug. ***
*** Bug 152401 has been marked as a duplicate of this bug. ***
*** Bug 160661 has been marked as a duplicate of this bug. ***
*** Bug 162892 has been marked as a duplicate of this bug. ***
*** Bug 185563 has been marked as a duplicate of this bug. ***
QA Contact: sheelar → gchan
Attached patch patch for review (obsolete) — — Splinter Review 
This patch works well. Pls review it. Thanks. :-)
Comment on attachment 109498 [details] [diff] [review]
patch for review

It's ok. 

r=henry
Attachment #109498 - Flags: superreview?(sspitzer)
Attachment #109498 - Flags: review+
accepting.  I'm looking into if the right fix involves switching over to a com
ptr, too.
Status: NEW → ASSIGNED
philip's approach looks good.  switching over to comptr is a bug for another day.

I'll test and land for him.
Assignee: sspitzer → philip.zhao
Status: ASSIGNED → NEW
Attached patch a different patch (obsolete) — — Splinter Review 
here's a slightly different patch that I'm testing, based on philip's patch.
Attachment #109498 - Attachment is obsolete: true

        Attachment #109549 -
        Attachment is obsolete: true

    
    

    
  
phillips patch might be the best one.

the ownership model for this save as code isn't 100% clear to me yet.

still testing.


    
    

    
  

      
      
      
      

        Attached patch
          
          
        still working on it. (obsolete)
        — 
          — Splinter Review
      

    


  
there was no need for the extra release in phillip's original patch, as the
listener was always null.

I'm still reviewing and my latest patch...

        Attachment #109550 -
        Attachment is obsolete: true

    
    

    
  
taking back from philip, but I'll credit him when I check in the patch.
Assignee: philip.zhao → sspitzer

    
    

    
  
fixed.

this has r/sr=bienvenu
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.3beta

    
    

    
  

      
      
      
      

        Attached patch
          
          
        final patch
        — 
          — Splinter Review
      

    


  

        Attachment #109557 -
        Attachment is obsolete: true

        Attachment #109498 -
        Flags: superreview?(sspitzer) → superreview-

    
    

    
  
Thanks sspitzer. The final one is really good.

    
    

    
  
commerical
2003-01-02-05-trunk Xp
2003-01-02-08-trunk Mac OS 10.1.2, linux 2.2

Verified when you do a file\save as and then hit the cancel button
in the dialog box that no message pops up at you.

marking as verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: