Last Comment Bug 1202061 - [SMS] Subject text overlaps MMS text inside the Message Report.
: [SMS] Subject text overlaps MMS text inside the Message Report.
Product: Firefox OS Graveyard
Classification: Graveyard
Component: Gaia::SMS (show other bugs)
: unspecified
: ARM Gonk (Firefox OS)
-- normal (vote)
: ---
Assigned To: jgw9617
Mentors: Julien Wajsberg [:julienw]
: 1150833 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2015-09-04 16:05 PDT by [:VladimirBelonenko]
Modified: 2017-02-17 06:17 PST (History)
8 users (show)
See Also:
QA Whiteboard: [QAnalyst-Triage+]
Iteration: ---
Points: ---

logcat_20150904_1549.txt (208.53 KB, text/plain)
2015-09-04 16:05 PDT, [:VladimirBelonenko]
no flags Details
screenshot0002.jpg (500.63 KB, image/jpeg)
2015-09-08 14:38 PDT, [:VladimirBelonenko]
no flags Details
Message report_text_wrap.jpg (402.12 KB, image/jpeg)
2015-09-14 23:48 PDT, Fang Shih [:fang]
no flags Details
[gaia] jgw96:long-subject-fix > mozilla-b2g:master (46 bytes, text/x-github-pull-request)
2015-12-07 22:04 PST, GitHub Autolander Bot
julienw: feedback-
Details | Review | Splinter Review

Description User image [:VladimirBelonenko] 2015-09-04 16:05:35 PDT
Created attachment 8657359 [details]

When you send SMS text with Subject text  and with message. The text will overlap. 

Repro Steps:
1) Update a Aries to 20150903161537
2) Launch the messanger app.
3) After typing phone number add a subject
4) Type couple lines of text of couple lines inside a subject body 
5) Send a message.
6) Click the message that you send, click on message and hold.
7) Click on Message Report

Observe that After MMS message is send. Inside the message report the subject text overlaps SMS text.

The subject text should not overlap SMS text inside the message body.

Environmental Variables:
Device: Aries 2.5 kk Full Flash (319 mb)
Build ID: 20150903161537
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: feee8b89453a42346f20753bd1b8a606c286f561
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 3/3
See attached: Video and Logcat
Comment 1 User image [:VladimirBelonenko] 2015-09-04 16:17:45 PDT
This issue also occurs on Flame 2.5
Report: Subject text overlaps MMS text inside the Message Report

Environmental Variables:
Device: Flame 2.5 kk Full Flash (319 mb)
Build ID: 20150903150222
Gaia: d7385b79e68d4ad662cacf810506e9ee53345d23
Gecko: 7f987c38bd3e5ac9a834981e85378bdb02338e9d
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0


This issue also occurs on Flame 2.2
Report  Subject text overlaps MMS text inside the Message Report

Environmental Variables:
Device: Flame 2.2 kk Full Flash (319 mb)
Build ID: 20150903183008
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: d3cb4f28c735
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Comment 2 User image [:VladimirBelonenko] 2015-09-08 14:38:53 PDT
Created attachment 8658384 [details]
Comment 3 User image KTucker [:KTucker][Inactive 3/4/2016] 2015-09-08 14:40:52 PDT
This issue is not a regression and seems minor so not nominating to block on this.
Comment 4 User image Steve Chung [:steveck] 2015-09-08 19:20:09 PDT
It should be relatively simple issue for css fix.
Comment 5 User image Julien Wajsberg [:julienw] 2015-09-10 12:43:20 PDT
This is happening with only a long word as a subject.

Morpheus, what should be the right behavior? Have an ellipsis for the long word (so we wouldn't see the full text.. but after all we see the full subject in the conversation panel already)? Or have it wrap in the middle of the word?
Comment 6 User image Morpheus Chen [:morpheus] UX 2015-09-13 21:27:01 PDT
The system has already defined a maximum length of subject. It means the text in the message report won't be too long to display. So I would recommend to wrap the text in the middle of the word, and take care of the overlapping and line spacing. Ni Fang to review the line spacing.
Comment 7 User image Fang Shih [:fang] 2015-09-14 23:48:56 PDT
Created attachment 8661096 [details]
Message report_text_wrap.jpg

Attached the spec for the line spacing. Thanks!
Comment 8 User image Julien Wajsberg [:julienw] 2015-12-03 06:30:43 PST
*** Bug 1150833 has been marked as a duplicate of this bug. ***
Comment 9 User image jgw9617 2015-12-06 23:11:53 PST
I would not mind taking this bug if somebody can assign it to me please! I already started looking at it, hopefully will have a good solution soon.
Comment 10 User image kumar rishav (:rishav_) 2015-12-06 23:20:50 PST
yeah, sure :) 
Feel free to comment if you stuck anywhere.

Comment 11 User image GitHub Autolander Bot 2015-12-07 22:04:18 PST
Created attachment 8696606 [details] [review]
[gaia] jgw96:long-subject-fix > mozilla-b2g:master
Comment 12 User image jgw9617 2015-12-07 22:06:22 PST
See PR for first attempt above! Let me know of any changes that need to be made, I tried to keep the necessary changes to a minimum.
Comment 13 User image kumar rishav (:rishav_) 2015-12-08 03:11:30 PST
Comment on attachment 8696606 [details] [review]
[gaia] jgw96:long-subject-fix > mozilla-b2g:master

Thanks for the PR. will check it soon :)
First go with feedback flag before review :)

Comment 14 User image jgw9617 2015-12-11 20:43:37 PST
Awesome! Let me know if any changes need to be made please
Comment 15 User image Julien Wajsberg [:julienw] 2015-12-12 05:12:40 PST
Yes, sorry for the delay, we've been all week long in a workweek. Normal work resumes next week.
Comment 16 User image jgw9617 2015-12-12 08:51:26 PST
No problem, sounds good to me.
Comment 17 User image Julien Wajsberg [:julienw] 2015-12-16 06:46:58 PST
Comment on attachment 8696606 [details] [review]
[gaia] jgw96:long-subject-fix > mozilla-b2g:master

Hey Justin,

Well, your patch does not work properly. Have you tried it at all ? You didn't change the main "index.html" but only conversation/index.html, and when I tried to display the report view, it's broken...

Also did you look at the attachment 8661096 [details] ? You'll find the spec to implement there.

Here are the main changes to the current behavior:
* use the default line-height (that is: "line-height: 1" instead of "line-height: 1.1rem"
* use better margin between lines. (currently we use a padding)
* there is an indentation when the text has several lines.

I'd suggest to use flexbox to implement this. You can have a look at [1] for more information.

Also the issue may happen in other places than just the subject, for example I see it could happen for dates as well, in rare cases.


I'd like that you at least test your code yourself before asking feedback. We can provide some guidance but it's easier if you do some of the check yourself, at least for the main case.

Thanks anyway for your work, I surely hope to find an updated patch soon !
Comment 18 User image Julien Wajsberg [:julienw] 2017-02-17 06:10:05 PST
Mass closing of Gaia::SMS bugs. End of an era :(
Comment 19 User image Julien Wajsberg [:julienw] 2017-02-17 06:17:44 PST
Mass closing of Gaia::SMS bugs. End of an era :(

Note You need to log in before you can comment on or make changes to this bug.