1202351 - Remove MDSM::mPlayDuration

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

After bug 1199562 is landed, MDSM can always rely on the MediaSink to provide the playback position no matter playback is paused or not. We can then remove |mPlayDuration| which existed to provide the playback position when playback is paused.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb59fc671256

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1202351 - Remove MDSM::mPlayDuration.

Bug 1202351 - Remove MDSM::mPlayDuration.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8658494 [details]
MozReview Request: Bug 1202351 - Remove MDSM::mPlayDuration.

https://reviewboard.mozilla.org/r/18615/#review16755

::: dom/media/MediaDecoderStateMachine.cpp:2549
(Diff revision 1)
> -
> +  auto clockTime = mMediaSink->GetPosition(aTimeStamp);

In general, "auto" should be used sparingly, and only when using it increases readability. Like for knarly template types on iterators.

When I see "auto" here I have to think to figure out what type it is. So I prefer we don't use "auto" for primitive types.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/18615/#review16755

> In general, "auto" should be used sparingly, and only when using it increases readability. Like for knarly template types on iterators.
> 
> When I see "auto" here I have to think to figure out what type it is. So I prefer we don't use "auto" for primitive types.

Will replace auto with int64_t. Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1d187c685d1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1d187c685d1