Closed
Bug 1202403
Opened 9 years ago
Closed 9 years ago
Use langpack.channel for the Get More Languages link in Settings > Language
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
Instead of using deviceinfo.os which comes from Gecko and isn't controlled by Gaia, we should use moz.b2g.version which is set in build/config/common-settings.json.
|
Assignee | |
Comment 1•9 years ago
|
||
In bug 1202407 I'll be renaming moz.b2g.version to langpack.channel.
Depends on: 1202407
Summary: Use moz.b2g.version for the Get More Languages link in Settings > Language → Use langpack.channel for the Get More Languages link in Settings > Language
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8659549 [details] [review] [gaia] stasm:1202403-get-more-languages-langpack.channel > mozilla-b2g:master EJ, can you take a look at this?
Attachment #8659549 -
Flags: review?(eragonj+moz)
Comment on attachment 8659549 [details] [review] [gaia] stasm:1202403-get-more-languages-langpack.channel > mozilla-b2g:master Hey Stas, I'll pass this to Fred to make sure he can test your patch to make sure things are not going wrong. If no problem, it would be r+ :) thanks.
Attachment #8659549 -
Flags: review?(eragonj+moz) → review?(gasolin)
|
||
Updated•9 years ago
|
Assignee: nobody → stas
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8659549 [details] [review] [gaia] stasm:1202403-get-more-languages-langpack.channel > mozilla-b2g:master Thanks for the patch and thanks EJ to forward the review. Looks good to me!
Attachment #8659549 -
Flags: review?(gasolin) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks! https://github.com/mozilla-b2g/gaia/commit/29991414eb94b6baa1ec2e63fdb4f6dfae05fb01
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•