1202770 - Clearing browsing history should not delete pinned pages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect, P2)

Comment 1

[Ben Francis [:benfrancis]]

This needs to block.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1202770-Clearing-private-data-should-not-delete-pinned-pages-or-pinned-site-icons > mozilla-b2g:master

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8671902 [details] [review]
[gaia] gmarty:Bug-1202770-Clearing-private-data-should-not-delete-pinned-pages-or-pinned-site-icons > mozilla-b2g:master

This patch ensures that pinned pages are not deleted when the browsing history is cleared.
Doing something similar with pinned sites and pages icons when the private data are cleared seems more complicated. Can we break down this bug into 2 different bugs to allow this patch to land quickly?

Comment 5

[Guillaume Marty [:gmarty]]

Comment on attachment 8671902 [details] [review]
[gaia] gmarty:Bug-1202770-Clearing-private-data-should-not-delete-pinned-pages-or-pinned-site-icons > mozilla-b2g:master

Dale, can you take a look at this patch?

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8671902 [details] [review]
[gaia] gmarty:Bug-1202770-Clearing-private-data-should-not-delete-pinned-pages-or-pinned-site-icons > mozilla-b2g:master

So I think ideally the solution would be to have a seperate store for pinned sites only, basically split out any data that would need to be cleared from data that needs persisted so those stores can be cleared entirely.

But for doing it this way the code + tests looks good.

Comment 7

[Guillaume Marty [:gmarty]]

Thanks for the review.
Landed in https://github.com/mozilla-b2g/gaia/commit/aec2c319e898b6cfce2d625217ccf669b5c8f88f

Comment 8

[Alison Shiue]

Verified on

[Flame]
Build ID               20151018150205
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151018.183443
Firmware Date          Sun Oct 18 18:34:55 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151018193102
Gaia Revision          f75a7e01912cee313fed92ff2089586f507b2ba5
Gaia Date              2015-10-16 13:00:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1a89632277fbaaf470c90a35573776048988f2d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151018.185054
Firmware Date          Sun Oct 18 18:51:02 UTC 2015
Bootloader             s1