Closed
Bug 1202974
Opened 9 years ago
Closed 9 years ago
[Settings] Convert call settings switches to use web components
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
No description provided.
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8658517 [details] [review] [gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master Hi Fred, Wondering if you could review this. I've verified the following things appear to appear visually correct (had to tinker in WebIDE to get to these states): Verified the following visuals work ok: * Voice privacy mode * Call waiting switch - normal state * Call waiting switch - unknown state * Call waiting dialog switch I'm not sure if there's anything else that needs to be covered. Thanks for the help!
Attachment #8658517 -
Flags: review?(gasolin)
Comment 3•9 years ago
|
||
Comment on attachment 8658517 [details] [review] [gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master Thanks for the patch. I leave sine comment on github. Due to the RTL patch is just landed to settings, there might be some change need to be addressed as well.
Attachment #8658517 -
Flags: review?(gasolin)
Comment 4•9 years ago
|
||
r/sine/some :p
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8658517 [details] [review] [gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master Hi Fred, Comments addressed and rebased against master. Please take a look if you can, thanks!
Attachment #8658517 -
Flags: review?(gasolin)
Comment 6•9 years ago
|
||
Comment on attachment 8658517 [details] [review] [gaia] KevinGrandon:bug_1202974_settings_call_switches > mozilla-b2g:master Looks fine except the opacity should be 0.3, or the text color will looks slightly different from the next item (Caller ID) while in waiting.
Attachment #8658517 -
Flags: review?(gasolin) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Thank you for the review! In master: https://github.com/mozilla-b2g/gaia/commit/b6c41238fb0de33af418621967de3eaa08b5099e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•