1203111 - webkitAudioContext is not defined on BBC gunfire effects generator

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[alexf_ba124]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150826023504

Steps to reproduce:

Loaded - http://webaudio.prototyping.bbc.co.uk/ in Firefox 
and then http://webaudio.prototyping.bbc.co.uk/ring-modulator/

clicnking one the speech buttons to start a smaple playing...


Actual results:

The sound played, but the controls on the represented tape deck are non functional and the sound plays in a loop.


Expected results:

The controls should enable the sound to be minipulated in line with their 'emulated' function.

Comment 1

[Karl Tomlinson (:karlt)]

There is a problem with drawing the controls, but the sound can be modulated when I test here with 41.0b6 or 43.0a1.  The sound loops in both Firefox and Chromium.

The sound is very different to Chromium, much more distorted, buzzy, perhaps clipped.

Comment 2

[Loic]

For the distorted audio in FF41+, it's a regression, see bug 1203616.

Comment 3

[Maire Reavy [:mreavy]]

Do you still see a problem with non-working controls?  What browser version, if so?

If not, we should close this; the quality issue has been addressed in bug 1203616

Comment 4

[Maire Reavy [:mreavy]]

Please reopen if this still is an issue (and likely would go in another component)

Comment 5

[wiki]

I've just re-tested in 43.0 - And whilst the controls draw perfectly, I get no response from them.

Comment 6

[Andreas Wagner [:TheOne] [use NI]]

Reopen as per comment 5.

Comment 7

[Maire Reavy [:mreavy]]

This appears to be a problem with the 'knob' implementation. Even in chrome the knob acts odd; the knob position doesn't track the mouse in a way I'd expect.  Likely there's a bug or chrome-dependency in the knob impl.

The knob source, however, is 404.  Please create a simplified example of just the knob and point to it or attach it.  Thanks!

Comment 8

[alexf_ba124]

Would on the basis of the above suggest a closure as this doesn't as such seem to be a Firefox isssue but one with the site concerned.

Comment 9

[alexf_ba124]

Okay tested in Firefox 49.0 

The first three examples ( Ring  Modulator, Wobulator, Tape loops) all work reasonably, the gunfire effects generator doesn't respond at all.

Comment 10

[Paul Adenot (:padenot)]

> ReferenceError: webkitAudioContext is not defined

Not much we can do here, over to evangelism, this is getting an AudioContext with the old, proprietary fashion, that only ever existed in Chrome and Safari, back in the days.

Comment 11

[Adam Stevenson [:adamopenweb]]

Updating the summary and URL based on comment 10 and setting as needsdiagnosis.

Comment 12

[Mike Taylor [:miketaylr]]

Like padenot said, in http://webaudio.prototyping.bbc.co.uk/js/gunfire.js?version=7d53ff5dc06fca3b6291dd20fa84025a55495c3c there is the following:

audioContext = new webkitAudioContext;

Assuming that's the only issue, something like this would work:

window.AudioContext = new (AudioContext || webkitAudioContext);

Comment 13

[alexf_ba124]

Not sure if there is a way to contact the BBC site easily, but they should ideally be notified about the older interface they use in the relevant script.

Thanks for fixing up the other control issues.

Comment 14

[Mike Taylor [:miketaylr]]

> they should ideally be notified about the older interface they use in the relevant script

Yep, the [needscontact] white label means someone from my team will get in touch with them (at some point, ideally soon).

Comment 15

[Adam Stevenson [:adamopenweb]]

Contacted BBC about this issue by our BBC discuss list.

Comment 16

[Chris Needham]

Thanks for letting us know about this. We're working to update the website to the latest Web Audio API spec. I'm not sure I'm on your BBC discuss list, please do add me.

Comment 17

[Adam Stevenson [:adamopenweb]]

Thanks Chris that's great! I sent an email about getting you added.

Comment 18

[Desigan Chinniah [:cyberdees] [:dees] [London - GMT]]

(In reply to Chris Needham from comment #16)
> Thanks for letting us know about this. We're working to update the website
> to the latest Web Audio API spec. I'm not sure I'm on your BBC discuss list,
> please do add me.

You have been added, Chris. I have emailed confirmation across.

Comment 19

[Mike Taylor [:miketaylr]]

This is fixed now, thanks Chris and BBC!