Closed
Bug 1203244
Opened 9 years ago
Closed 9 years ago
Huge context menu after right click in message [ReferenceError: GetThreadTree is not defined] in mailContextMenus.js
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(thunderbird42 unaffected, thunderbird43+ fixed, thunderbird44 fixed)
RESOLVED
FIXED
Thunderbird 44.0
Tracking | Status | |
---|---|---|
thunderbird42 | --- | unaffected |
thunderbird43 | + | fixed |
thunderbird44 | --- | fixed |
People
(Reporter: ssitter, Assigned: alta88)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
1.51 KB,
patch
|
mkmelin
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Thunderbird/43.0a1 (Build ID 20150909030202) Lightning 4.5a1 is installed but disabled. Steps to reproduce: * Start Thunderbird with clean profile * Skip system integration and initial account creation * Create a Feed account to stop Thunderbird for asking for accounts * Download and save the .eml file from https://bugzilla.mozilla.org/attachment.cgi?id=8658787&action=edit * Use File > Open Saved Message to view the message in new window * Right click into message content Actual Results: Context menu is huge with many entries. Error Console shows: Error: ReferenceError: GetThreadTree is not defined Source File: chrome://messenger/content/mailContextMenus.js Line: 64 Error: TypeError: gContextMenu is undefined Source File: chrome://messenger/content/mailContextMenus.js Line: 50 Works in Earlybird 42.0a2 (2015-09-09). Probably regressed by Bug 500610.
Reporter | ||
Updated•9 years ago
|
Keywords: regression
Assignee: nobody → alta88
Attachment #8658850 -
Flags: review?(mkmelin+mozilla)
Comment 2•9 years ago
|
||
Comment on attachment 8658850 [details] [diff] [review] context.patch Review of attachment 8658850 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailContextMenus.js @@ +60,5 @@ > return true; > > // No menu on grouped header row currently, any command would be an implied > // multiselect. > + if (gFolderDisplay.tree) { what's gFolderDisplay.tree?
the same thing as GetThreadTree() and null in a message window. another global func that can be gotten rid of.
Comment 4•9 years ago
|
||
Comment on attachment 8658850 [details] [diff] [review] context.patch Review of attachment 8658850 [details] [diff] [review]: ----------------------------------------------------------------- Looks good thx. I'll attach an unbitrotted patch.
Attachment #8658850 -
Flags: review?(mkmelin+mozilla) → review+
Comment 5•9 years ago
|
||
Attachment #8658850 -
Attachment is obsolete: true
Attachment #8663801 -
Flags: review+
Updated•9 years ago
|
Attachment #8663805 -
Flags: review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3e27b83156b6
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
Updated•9 years ago
|
Target Milestone: Thunderbird 43.0 → Thunderbird 44.0
Reporter | ||
Comment 9•9 years ago
|
||
Verified fixed using Thunderbird 44.0a1 (20150922030229).
Reporter | ||
Comment 10•9 years ago
|
||
Comment on attachment 8663805 [details] [diff] [review] context.patch [Approval Request Comment] Regression caused by (bug #): bug 500610 User impact if declined: broken context menu Testing completed (on c-c, etc.): see comment 9 Risk to taking this patch (and alternatives if risky):
Attachment #8663805 -
Flags: approval-comm-aurora?
Reporter | ||
Updated•9 years ago
|
status-thunderbird43:
--- → affected
Reporter | ||
Updated•9 years ago
|
status-thunderbird42:
--- → unaffected
tracking-thunderbird43:
--- → ?
Comment 11•9 years ago
|
||
Comment on attachment 8663805 [details] [diff] [review] context.patch http://hg.mozilla.org/releases/comm-aurora/rev/ca799fe0e2fe
Attachment #8663805 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•