1203868 - SyncEngine not retrieving latest records

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

Attachment: irc log from #fxos-sync

irc log from #fxos-sync attached.

Comment 1

[Michiel de Jong [:michielbdejong]]

Fixed in https://github.com/michielbdejong/syncto/tree/6-original-ids I think.

Comment 2

[Michiel de Jong [:michielbdejong]]

I'll leave the ?_since= header commented out in https://github.com/michielbdejong/gaia/tree/1200539-sync-app-integration-tests until the 6-original-ids branch lands into Syncto master, then it should all work together.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Attachment: Fixing JSON.parse error

Hi Michiel,

After applying Natim's patch at https://github.com/mozilla-services/syncto/pull/19, I still got JSON.parse error.

So I provide my patch for fixing the error in SyncEngine. Could you give me a feedback? Thank you!

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8659970 [details]
Fixing JSON.parse error

Hi Sean,

(In reply to Sean Lee [:seanlee] from comment #3)
> After applying Natim's patch at
> https://github.com/mozilla-services/syncto/pull/19, I still got JSON.parse
> error.
> 
> So I provide my patch for fixing the error in SyncEngine. Could you give me
> a feedback? Thank you!

RemoteTransformer.decode should never be called with data that does not need decoding. If that is happening then we need to fix that in kinto.js rather than working around it in this way.

I also saw JSON.parse errors yesterday morning, but last time I tested with the latest version of https://github.com/michielbdejong/gaia/tree/1200539-sync-app-integration-tests I did not see any JSON parse errors. Can you provide the steps to reproduce?

Comment 5

[Michiel de Jong [:michielbdejong]]

Closing this as UNCONFIRMED since I haven't seen it happen in the last two weeks.

Please reopen if we can reproduce it!