1204132 - Remove _signal argument to various methods

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, enhancement, P5)

Description

[Mathieu Pillard [:mat]]

Some methods in zamboni (particularly ModelBase.update()) have a special _signal argument that can be set to prevent this method from firing signals like post_save.

It makes code more complicated and harder to follow. We should not prevent signals from being sent, we should write the signal handlers correctly to avoid issues.

One particular use-case we should look at is _signal=False passed in post_save handlers that do a .save() or .update() themselves. Maybe some of those handlers should be trigged on pre_save instead and just set the properties they want on the instance without triggering a .save()/.update(), letting the regular .save() call that is going to happen afterwards deal with saving the changes.