Closed
Bug 1204584
Opened 9 years ago
Closed 9 years ago
Psuedo frames created by js::AutoSPSEntry don't get their category propogated
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 2 obsolete files)
6.18 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•9 years ago
|
||
This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.
Attachment #8662083 -
Flags: review?(kvijayan)
Assignee | ||
Comment 2•9 years ago
|
||
Verified that this also fixes bug 1164344 and that the category information is indeed passed along now.
Comment 3•9 years ago
|
||
Comment on attachment 8662083 [details] [diff] [review] Ensure that entries created by AutoSPSEntry propogate their category information Review of attachment 8662083 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/public/ProfilingStack.h @@ +134,5 @@ > return flags_ & CATEGORY_MASK; > } > void setCategory(Category c) volatile { > + MOZ_ASSERT(c != Category::FIRST); > + MOZ_ASSERT(c != Category::LAST); This assert seems wrong to me. FIRST and LAST are valid categories (aliases for OTHER and EVENTS). Shouldn't it be something like: MOZ_ASSERT(c >= Category::FIRST && c <= Category::LAST) ??
Assignee | ||
Comment 4•9 years ago
|
||
This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.
Attachment #8662083 -
Attachment is obsolete: true
Attachment #8662083 -
Flags: review?(kvijayan)
Attachment #8662583 -
Flags: review?(kvijayan)
Assignee | ||
Comment 5•9 years ago
|
||
This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.
Attachment #8662583 -
Attachment is obsolete: true
Attachment #8662583 -
Flags: review?(kvijayan)
Attachment #8662596 -
Flags: review?(kvijayan)
Updated•9 years ago
|
Attachment #8662596 -
Flags: review?(kvijayan) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08d5c8ba076d
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f33142322571
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•