Closed Bug 1204827 Opened 9 years ago Closed 9 years ago

Generate xClientState inside SyncEngine

Categories

(Firefox OS Graveyard :: Sync, defect)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S8 (02Oct)

People

(Reporter: mbdejong, Assigned: mbdejong)

References

Details

(Whiteboard: [partner-cherry-picked<2015/11/10>])

Attachments

(1 file)

[gaia] michielbdejong:1204827-xClientState > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
Details | Review 
The correct value for the X-Client-State header can easily be derived from kB, like described in https://bugzilla.mozilla.org/show_bug.cgi?id=959919#c13, so it should not be a required option in the SyncEngine constuctor.
Assignee: nobody → mbdejong
Blocks: 1195647
Blocks: 1204432
Target Milestone: --- → FxOS-S8 (02Oct)
Attachment #8664220 - Flags: review?(ferjmoreno)
Comment on attachment 8664220 [details] [review]
[gaia] michielbdejong:1204827-xClientState > mozilla-b2g:master

Thanks!
Attachment #8664220 - Flags: review?(ferjmoreno) → review+
https://github.com/mozilla-b2g/gaia/commit/6fc28d55fa9a595804f30cf1ba900fe1be93685d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: partner-cherry-pick
Whiteboard: partner-cherry-pick
Whiteboard: [partner-cherry-pick]
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: