Closed
Bug 1205265
Opened 9 years ago
Closed 9 years ago
CSS in privacy/tips page in mozilla.org needs Romanian-specific CSS rule for quote marks
Categories
(www.mozilla.org :: L10N, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jobaval10n, Assigned: jobaval10n)
Details
The Romanian language uses quote marks in this style: „ ” In English, it's "" or “” If you look at this page: https://www.mozilla.org/ro/privacy/tips/ the right side quote in green and italic has English-style quotemarks, and they should be Romanian: „” The en-US page: https://www.mozilla.org/en-US/privacy/tips/ Probably some other locales also need their own specific quote marks in that less rule (German or Russian): https://www.mozilla.org/ru/privacy/tips/ (should be « » like in French) https://www.mozilla.org/de/privacy/tips/ (should be „ “ for Germany and Austria) Thanks to Cristi Silaghi for bringing this matter to my attention. I have a pending github pull request https://github.com/mozilla/bedrock/pull/3323 which will be updated later after more testing, if that's necessary.
Updated•9 years ago
|
Assignee: nobody → jobaval10n
Fix implemented. Screenshot: https://i.imgur.com/HPvb8G8.png
Comment 2•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/bb1d29a7457996f98dfd1f2b3122ee3755efd8a4 Bug 1205265 - Use proper quotes for Romanian in privacy/tips https://github.com/mozilla/bedrock/commit/bf7fba60797b485e2a2186fd09a09cb4700a4d33 Merge pull request #3323 from Jobava/master Bug 1205265 - Use proper quotes for Romanian in privacy/tips
Comment 3•9 years ago
|
||
Using the bug reference in the PR and commit message makes automation a lot easier ;-) https://www-dev.allizom.org/ro/privacy/tips/ Will be pushed to production early next week, then you should mark the bug as verified. Again, great job!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•