1205288 - implement and test fetch spec changes for blob scheme with non-GET method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

See:

  https://github.com/whatwg/fetch/issues/125

Basically a non-GET Request for a blob: scheme URL should result in a NetworkError.  Its possible we already implement this, but we should write a test.  Preferably a WPT test.

Comment 1

[Dimi Lee [:dimi]]

I would like to take this bug.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Patch - check non-GET for blob, with mochitest

Hi Ben,
I add a mochitest for this because there is already tests for fetch blob. please let me know if you prefer also adding a WPT.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8704047 [details] [diff] [review]
Patch - check non-GET for blob, with mochitest

Review of attachment 8704047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thanks!

Do you know if we check this in XHR as well?

Comment 4

[Dimi Lee [:dimi]]

(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8704047 [details] [diff] [review]
> Patch - check non-GET for blob, with mochitest
> 
> Review of attachment 8704047 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good.  Thanks!
> 
> Do you know if we check this in XHR as well?

No, i write a test and blob is load successfully with POST.

Comment 5

[Dimi Lee [:dimi]]

Attachment: Patch - check non-GET for blob, with mochitest v2

Update commit message.

Also run try:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da18a713b23

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4ef7073bb5

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f4ef7073bb5