1205470 - Assertion failure: !self->mInitPromise.IsEmpty(),

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1105760#c465


PROCESS | 1863 | Assertion failure: !self->mInitPromise.IsEmpty(), at
/builds/slave/fx-team-l64-d-0000000000000000/build/src/dom/media/mediasource/MediaSourceDemuxer.cpp:66
PROCESS-CRASH | /media-source/SourceBuffer-abort-readyState.html | application
crashed [@
nsRunnableFunction<mozilla::MediaSourceDemuxer::NotifyDataArrived(uint32_t,
int64_t)::<lambda()> >::Run]
TEST-UNEXPECTED-CRASH | /media-source/SourceBuffer-abort-readyState.html |
expected OK
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
SSLError: [Errno 1] _ssl.c:1242: error:1409F07F:SSL
routines:SSL3_WRITE_PENDING:bad write retry
Return code: 1


We have a race accessing the init promise should shutdown occurs prior everything.
I had thought about and thought that it didn't matter. Prove njn's point I gather ; there's no such thing as a trivial race

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] Remove assertion.

Can also remove mInitDone member as that information is redundant with the init promise being present

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44be220d93ec

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44be220d93ec

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8663476 [details] [diff] [review]
[MSE] Remove assertion.

Approval Request Comment
[Feature/regressing bug #]:1204757
[User impact if declined]: Assert.
[Describe test coverage new/current, TreeHerder]: in central
[Risks and why]: Low, removing assertion
[String/UUID change made/needed]: none

Comment 6

[Jean-Yves Avenard [:jya]]

Seems this one flew under the radar... Any particular reason for the request to still be pending?

thank you

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8663476 [details] [diff] [review]
[MSE] Remove assertion.

Because I am managing 42 and not 43. Therefor, I am watching only the beta uplift requests.
Anyway, taking it to fix the assert.

Comment 8

[Jean-Yves Avenard [:jya]]

Ah ok . I see.. thanks

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d1337291612