1205474 - Don't allow add-ons with just whitespace as name

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Create an add-on with just whitespace as name
2. Submit the add-on to marketplace-dev

expected behavior:
Even though the spec doesn't disallow it, we should not allow add-ons with just whitespace as their name.

actual behavior:
We allow these add-ons but they show up in Reviewer tools without a name making it impossible to access the details page. See https://www.dropbox.com/s/j4bt692rnfzgu7u/Screenshot%202015-09-16%2016.11.00.png?dl=0

Comment 1

[Andrew Williamson [:eviljeff]]

The spec doesn't explicitly disallow it, but I suspect the other add-on stores that support these style of extensions wouldn't allow it either.  Also IMO pure whitespace is empty for all intents so we shouldn't allow it, regards of what Google and Opera do.

Comment 2

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/9a1a685f0bfd38801c7a43805f5f1de366ae910a

Comment 3

[krupa raj[:krupa]]

we now show the error message - The `name` property must be at least 1 character long and can not consist of only whitespace characters.


Marking this as verified.