1205488 - Add explanatory note to parent review dialog

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

Parent review requests continue to confuse people.  We need to add a note explaining what they're for, to at least the review dialog.  The main commits view might need one too, but that can be done separately.

Comment 1

[Mark Côté [:mcote]]

Attachment: MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add explanatory note to review dialog for parent requests (bug 1205488). r?mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

I'm also not sure "MRParents" is a good name for the JavaScript extension,
but I'm not sure what is.

Comment 2

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/19507/#review17531

For the extension name, what about ParentReviewMessage or something like that?

::: pylib/mozreview/mozreview/static/mozreview/js/parents.js:21
(Diff revision 1)
> +  initialize: function() {
> +    _super(this).initialize.call(this);
> +  }

Isn't this superfluous?

Can you please attach a screenshot of the message?

Comment 3

[Mark Côté [:mcote]]

https://reviewboard.mozilla.org/r/19507/#review17531

So this is what I was torn about--do we have one extension that may later include more things, in which case we want a more generic name, or do we use multiple extensions, in which case we have more specific names?  I feel like it should be the former, since we can have a bunch of different hook views, but I'm not sure.  Maybe this is a question for smacleod.

Comment 4

[Mark Côté [:mcote]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add explanatory note to review dialog for parent requests (bug 1205488). r?mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

I'm also not sure "MRParents" is a good name for the JavaScript extension,
but I'm not sure what is.

Comment 5

[Mauro Doglio [:mdoglio]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

https://reviewboard.mozilla.org/r/19509/#review17667

Comment 6

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/19509/#review17669

Comment 7

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/19507/#review17671

Comment 8

[Mark Côté [:mcote]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

Comment 9

[Mark Côté [:mcote]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

Comment 10

[Mauro Doglio [:mdoglio]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

https://reviewboard.mozilla.org/r/19509/#review21251

Comment 11

[Mark Côté [:mcote]]

Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

Comment 12

[Mark Côté [:mcote]]

Okay I really wanted to add a note to the diff-comment dialog, since, as smacleod pointed out, if you go directly to the diff it scrolls you down, often past the main panel entirely.  That means people may not see the warning until they click "Finish Review..." which is kind of rude, as they may have already entered a bunch of comments.  But I could not figure out how to add text to the diff-comment dialog and get it to resize properly.  I really want to land the rest of this, so maybe we can follow up later.

http://hg.mozilla.org/hgcustom/version-control-tools/rev/c828c8876354