Closed
Bug 1205796
Opened 9 years ago
Closed 9 years ago
Coverity 1323784 indicates a useless passed-by-value argument in nsEditorSpellCheck::TryDictionary
Categories
(Firefox :: Untriaged, defect)
Tracking
()
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: u493164, Assigned: u493164)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1323784])
Attachments
(1 file, 2 obsolete files)
|
1.74 KB,
patch
|
u493164
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 Build ID: 20150917192208 Steps to reproduce: Coverity indicates that the first argument aDictName [1] could be passed by reference. [1] https://dxr.mozilla.org/mozilla-central/source/editor/composer/nsEditorSpellCheck.cpp#743
|
||
Updated•9 years ago
|
Assignee: nobody → calixte.denizet
Attachment #8662567 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8662567 [details] [diff] [review] bug1205796.patch Oops, I missed this while reviewing. The param should be const nsAString& aDictName with that, r+
Attachment #8662567 -
Flags: review?(bugs) → review+
Comment on attachment 8664095 [details] [diff] [review] bug1205796_2.patch Review of attachment 8664095 [details] [diff] [review]: ----------------------------------------------------------------- carrying r+ from Olli
Attachment #8664095 -
Flags: review+
Keywords: checkin-needed
Attachment #8662567 -
Attachment is obsolete: true
Attachment #8664095 -
Attachment is obsolete: true
Attachment #8664095 -
Attachment is obsolete: false
Attachment #8664110 -
Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/5edc7a3188ee
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•