Closed
Bug 1206102
Opened 9 years ago
Closed 9 years ago
Make the TP list names more flexible from a l10n standpoint
Categories
(Firefox :: Settings UI, defect, P1)
Firefox
Settings UI
Tracking
()
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: past, Assigned: past)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file, 1 obsolete file)
7.57 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
Bug 1177085 introduced a block list dialog that presents some UI challenges for localizers, due to the length of the strings. Paolo suggested that we could split the strings now, so that future improvements to the text layout could be independent of the localization efforts (hence easy to uplift).
Assignee | ||
Comment 1•9 years ago
|
||
Paolo, is this what you had in mind?
Attachment #8662953 -
Flags: review?(paolo.mozmail)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8662953 [details] [diff] [review] Patch v1 Francesco, are we correct in understanding that splitting the name in two before the uplift will be beneficial to localizers in case we find a nice way to format the text later?
Attachment #8662953 -
Flags: feedback?(francesco.lodolo)
Comment 3•9 years ago
|
||
Comment on attachment 8662953 [details] [diff] [review] Patch v1 Review of attachment 8662953 [details] [diff] [review]: ----------------------------------------------------------------- Yes, it would definitely help. In that case we could fix the JS in mozilla-aurora and leave mozNameTemplate unused until it can be removed in mozilla-central. ::: browser/locales/en-US/chrome/browser/preferences/preferences.properties @@ +41,2 @@ > # LOCALIZATION NOTE (mozstdName, etc.): These labels appear in the tracking > # protection block lists dialog. They are the names of the block lists. I'd be more explicit with the comment, just to avoid people trying to change the structure of the sentences. # LOCALIZATION NOTE (mozstdName, etc.): These labels appear in the tracking # protection block lists dialog, mozNameTemplate is used to create the final # string. Note that in the future these two strings (name, desc) could be # displayed on two different lines.
Attachment #8662953 -
Flags: feedback?(francesco.lodolo) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks, I've made the suggested comment change.
Attachment #8662953 -
Attachment is obsolete: true
Attachment #8662953 -
Flags: review?(paolo.mozmail)
Attachment #8662971 -
Flags: review?(paolo.mozmail)
Comment 5•9 years ago
|
||
Comment on attachment 8662971 [details] [diff] [review] Patch v2 Review of attachment 8662971 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this is what I had in mind for the localization. I guess I'd simplify some of the code but it's not a big deal, feel free to land as is with the strings for now, we can always iterate later.
Attachment #8662971 -
Flags: review?(paolo.mozmail) → review+
Updated•9 years ago
|
Iteration: --- → 43.3 - Sep 21
Flags: qe-verify?
https://hg.mozilla.org/mozilla-central/rev/c4bc60ef00fc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in
before you can comment on or make changes to this bug.
Description
•