Closed Bug 1206122 Opened 9 years ago Closed 9 years ago

Implement Switch To Parent Frame command

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ato, Assigned: automatedtester)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

Attachments

(1 file)

Marionette is missing the Switch To Parent Frame command that WebDriver specifies.

Instead Marionette currently lets you switch to the parent frame by the same mechanism that Selenium has, which is to pass an empty string to switchToFrame.

We can probably leave this behaviour there for the time being, until we’ve moved existing tests and client bindings over to this new command.

This was originally reported by Alexei Barancev in https://github.com/jgraham/wires/issues/22.
I was wrong in the description.  Passing an empty string to Switch To Frame will switch to the top-most frame, and not the parent frame.

This, then, is about implementing Switch To Parent Frame as defined in the specification: https://w3c.github.io/webdriver/webdriver-spec.html#switch-to-parent-frame
Assignee: nobody → dburns
Bug 1206122: Add support for switchToParentFrame r?jgriffin

This allows us from a child frame to go up one level. This is documented
at http://w3c.github.io/webdriver/webdriver-spec.html#switch-to-parent-frame
Attachment #8675889 - Flags: review?(jgriffin)
Attachment #8675889 - Flags: review?(jgriffin) → review+
Comment on attachment 8675889 [details]
MozReview Request: Bug 1206122: Add support for switchToParentFrame r?jgriffin

https://reviewboard.mozilla.org/r/22489/#review20167

lgtm
https://hg.mozilla.org/mozilla-central/rev/fa277d3857e2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: