12062 - Framesets not recognised when improperly nested

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[dwindlehop]

Trying this URL with the last build of Aug 17 gives the following error:

If you are not able to see this page, it is because your browser doesn't
support the frames feature, acquire a frames capable browser to view
this page.

Comment 1

[karnaze (gone)]

Reassigning to Eric.

Comment 2

[Nicholas Cull]

Attachment: Testcase showing frameset improperly contained in BODY element.

Comment 3

[Nicholas Cull]

Attachment: Testcase showing frameset contained in unknown element.

Comment 4

[Nicholas Cull]

Attachment: Testcase showing frameset contained in element that is child of the HEAD element.

Comment 5

[Nicholas Cull]

Tested on Apprunner, build 1999081709 (M9), on Windows 95.

The problem appears to be that the frameset is improperly nested inside some
other element. It doesn't appear to matter that the element is not a known HTML
element. The notable case that may cause many existing pages to break is when
the frameset is a child of the BODY element.

Strangely, if the frameset is a child of the HEAD element, or some other element
that is a child of the HEAD element, the frameset works as expected.

Comment 6

[Nicholas Cull]

This problem may also be related to bug 9059.

Comment 7

[Eric Pollmann]

Harish, these are some more malformed cases where framesets are not put in the
content model.

The first case doesn't work in Nav, IE, or Gecko.

The second case works in Nav and IE but not Gecko - this is the one that we
should maybe look at correcting.

The third case works in all three.

Can you take a look?  Thanks!

Comment 8

[harishd]

Fix is in:)  We should be ok...

Marking bug fixed.

Comment 9

[rubydoo123]

the first attached test case does not render as described. However, since it is
malformed HTML, it should not render as the reporter believes it should. The DTD
explicitly states that a frame/frameset is not allowed within the BODY element.
An HTML file is either comprised of the BODY element or the FRAMESET element.
The other two render correctly.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/280831a23967
[components] For https://github.com/mozilla-mobile/android-components/issues/12062: Fix onCreditCardsFetch tests.
https://hg.mozilla.org/integration/autoland/rev/219c696b39c2
[components] For https://github.com/mozilla-mobile/android-components/issues/12062: Allow toggling addresses autofill.
https://hg.mozilla.org/integration/autoland/rev/35e78092457d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
https://hg.mozilla.org/integration/autoland/rev/6a51e39089e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser (https://github.com/mozilla-mobile/fenix/pull/16099)
https://hg.mozilla.org/integration/autoland/rev/60a44fca7a1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062: Switch to consumeFlow and add tests
https://hg.mozilla.org/integration/autoland/rev/dde935b67c2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Remove feature flag for return to browser (https://github.com/mozilla-mobile/fenix/pull/16622)