1206214 - [Gallery] Tapping on inactive "Share" or "Trash" button cause selecting underlying image

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Max Ivanov[:MaxIvanov]]

Attachment: logs.txt

Description:
In the Gallery with 15 or more images and no images is selected if a user tap on the inactive "share" or "trash" button underlying image will be selected.


Repro Steps:
1) Update a Flame to 20150918041952
2) Add 15 or more images to the Gallery
3) Open Galery and tap on the "select" button
3) Tap on the "share" or "trash" button

Actual:
Image is selected


Expected:
Nothing happens

Environmental Variables:
Device: Flame 2.5
Build ID: 20150918041952
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0


Repro frequency: (100%)
See attached: (video clip, logcat)
https://youtu.be/cSB4V3Q71tM

Comment 1

[Max Ivanov[:MaxIvanov]]

This issue does occur on Flame 2.5 and Aries 2.5 as well as on Flame 2.2
Result: Underlying image will be selected

Device: Flame 2.5 Kk Full flash (319mb)
Build ID: 20150918041952
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
-----------------------------------------------------------------
Device: Flame 2.2 Kk Full flash (319mb)
Build ID: 20150918063047
Gaia: 95950c9d48ad2fc2da7686c2b133b750a99cd3da
Gecko: 38d6133e2416
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-------------------------------------------------------------------

Device: Aries 2.5
Build ID: 20150918122511
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Not a regression so not nominating to block but it seems like something that should be fixed. No-Jun, can you take a look at this please.

Comment 3

[No-Jun Park [:njpark]]

I am sort of surprised that this isn't a regression.  It does look quite unpolished though, since intuition tells me that tapping inactive overlay shouldn't do anything instead of selecting the image 'underneath' it. (Unless this is by design) :tif, what do you think?  Do you think it's serious enough to be a blocker or should we mark it as 'polish' bug?

Comment 4

[No-Jun Park [:njpark]]

tentatively marking it as a 'polish' bug until tif confirms otherwise.

Comment 5

[Tiffanie Shakespeare [:tif]]

Assuming it's fairly easy to de-select an image (which it looks like), it's not a blocking bug but it should be fixed in 2.6.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] SmirnovAndrey:bug-1206214-inactive-share > mozilla-b2g:master

Comment 7

[Alexey Yakimov]

Comment on attachment 8695262 [details] [review]
[gaia] SmirnovAndrey:bug-1206214-inactive-share > mozilla-b2g:master

Punam, could you please review this simple patch?

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 8695262 [details] [review]
[gaia] SmirnovAndrey:bug-1206214-inactive-share > mozilla-b2g:master

Hi Alexey

Thanks for looking into this issue and submitting the patch. It fixes the issue. The only reason its r- is to help improve readability by bringing in the pointer-event selector in existing declaration (See github). Thanks!

Comment 9

[Punam Dahiya [:pdahiya]]

Hi Alexey

Setting NI flag to update and land the patch. Please feel free to NI me if you need help to land the patch. Thanks!

Comment 10

[BMO Automation]

Firefox OS is not being worked on