Closed
Bug 1206419
Opened 9 years ago
Closed 9 years ago
Number textboxes are too tall
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
VERIFIED
FIXED
mozilla44
People
(Reporter: quicksaver, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(2 files)
66.72 KB,
image/jpeg
|
Details | |
608 bytes,
patch
|
Gijs
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In the latest nightly the number textboxes are too tall; see screenshot (Firefox Options - Advanced pane - Network tab). Last good build: https://hg.mozilla.org/mozilla-central/rev/de0e763b521062d9a9da0ce029792be026886223 [1] First bad build: https://hg.mozilla.org/mozilla-central/rev/214fe6c504eca1de730ab8234a2649c36ae3cd96 [2] [1] http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1442494674/ [2] http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1442526954/
Reporter | ||
Comment 1•9 years ago
|
||
Almost sure bug 1205100 caused this. Since Gijs will be gone till tuesday, Dao, thoughts?
Blocks: 1205100
Flags: needinfo?(dao)
Assignee | ||
Comment 2•9 years ago
|
||
Assignee: nobody → dao
Status: NEW → ASSIGNED
Flags: needinfo?(dao)
Attachment #8665387 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Comment on attachment 8665387 [details] [diff] [review] patch Review of attachment 8665387 [details] [diff] [review]: ----------------------------------------------------------------- or "unset", maybe? Either way, r=me
Attachment #8665387 -
Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/cae952a43d9d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8665387 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: bug 1205100 [User impact if declined]: see comment 0 [Describe test coverage new/current, TreeHerder]: [Risks and why]: pretty much risk-free [String/UUID change made/needed]:
Attachment #8665387 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8665387 [details] [diff] [review] patch Small ui fix, please uplift to aurora.
Attachment #8665387 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2f4c59d36486
status-firefox43:
--- → fixed
Reporter | ||
Comment 9•9 years ago
|
||
Verified fixed in both nightly and aurora as soon as each was updated to the latest builds with the patch.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•