Closed Bug 1206771 Opened 9 years ago Closed 9 years ago

Mozilla-beta fails to build: variable 'reentrantFlag' set but not use

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: Sylvestre, Assigned: mcmanus)

Details

Attachments

(1 file)

From 5cf027e9a6fd554bf02f79ffbf6442caf28d86c5 Mon Sep 17 00:00:00 2001
1.26 KB, patch
jduell.mcbugs
: review+
Details | Diff | Splinter Review 
/builds/slave/m-beta-lx-00000000000000000000/build/netwerk/protocol/http/nsHttpTransaction.cpp:769:17: error: variable 'reentrantFlag' set but not used [-Werror=unused-but-set-variable] 

This is blocking the build of 42beta1.
Summary: Mozilla-beta fails to build → Mozilla-beta fails to build: variable 'reentrantFlag' set but not use
Guys, can you help? Thanks
Flags: needinfo?(mcmanus)
Flags: needinfo?(daniel)
Once a patch is r+, please consider that you have a blanket approval to land that directly into m-b.
The patch should be trivial.
status-firefox42: --- → affected
status-firefox43: --- → ?
status-firefox44: affected → unaffected
heh - the compiler figured out that's eval'd debug only in beta even though it has four state changes.

I'll add a LOG statement with it - that will chill out the compiler without changing behavior.
bug 1206771 - fix reentrantFlag compiler warning on >= beta r=mayhemer
Attachment #8663754 - Flags: review?(jduell.mcbugs)
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #8663754 - Flags: review?(jduell.mcbugs) → review+
my plan is to land this after I have an opt build finish to confirm the issue.. but if someone is itchier than that, go ahead and steal it.
Flags: needinfo?(mcmanus)
my clang doesn't figure out there is an error there, so I can't confirm the bug. Will just push and let treeherder decide I guess.
Flags: needinfo?(daniel)
I was able to confirm and verify with g++ on linux64
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thanks for the quick reaction, this is appreciated :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: