1206998 - Long-press link menu should offer Send Tab and/or Share

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

Right now the only way to send a page to another device is to load it. Given that there are usually only a couple of things in the menu, Send seems like a good addition.

Comment 1

[Darrin Henein [:darrin]]

This seems like a great idea. Do we want only 'Send Tab' to start?

Comment 2

[Richard Newman [:rnewman]]

I'd love the iOS share sheet to be in there; quick access to Pocket/Whatsapp/etc.

That might even be enough as a first step, given that Send Tab will be in the share sheet.

Comment 3

[hennes]

Attachment: Pull request

This adds a "Share Link" option to the long press action sheet.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Has this been tested on iPad too?

Comment 5

[hennes]

(In reply to Stefan Arentz [:st3fan] from comment #4)
> Has this been tested on iPad too?

Good call, Stefan! I just tested on the iPad simulator and found that the second popover (after tapping "Share Link") was not positioned correctly because the tap location was queried too late from the gesture recognizer. I rebased the PR on master and added the fix.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Thank you :-)

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8687692 [details] [review]
Pull request

Code looks good - just need one more rebase and Ill give it a test run and merge it in.

Comment 8

[hennes]

(In reply to Stephan Leroux [:sleroux] from comment #7)
> Code looks good - just need one more rebase and Ill give it a test run and
> merge it in.

Thanks for reviewing, Stephan. I just rebased the PR again.

Comment 9

[Stephan Leroux [:sleroux]]

Thanks for all the rebasing.

master ecbd4ec8490a0fc6bd523da0c71d6257fb3ff9fa