1207329 - Cannot use markdown syntax to linkify text

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect)

Description

[u279076]

I'm unable to linkify bit.ly URLs in One & Done.

"[Click this link](http://bit.ly/1OsX2yJ)" results in the following URL:
> https://oneanddone.mozilla.org/en-US/tasks/143/a href="http://bit.ly/1OsX2yJ" rel="nofollow" http://bit.ly/1OsX2yJ</a

I can work around this by putting the URL in plain text like so:
> Click this link: http://bit.ly/1OsX2yJ

Comment 1

[Rebecca Billings [:rbillings]]

This repros the same with any link, it's not just bit.ly URLs. The editor we use requires this format. I don't know of a way to link text to a specific URL - perhaps bsilverberg will know a work around.

Comment 2

[Bob Silverberg [:bsilverberg]]

I tried a couple of different markdown sytnaxes which are supposed to work for links and I can confirm that they do not. We use a package called Markdown [1] to do the rendering so it might be a bug with that. I am going to try updating to the latest version (as we are on an older one) to see if that helps.

[1] https://pypi.python.org/pypi/Markdown

Comment 3

[Bob Silverberg [:bsilverberg]]

It turns out this wasn't a problem with the package, but a bug in the code. I have fixed it in a pull request [1] which we'll try to get merged and pushed to prod soon.

[1] https://github.com/mozilla/oneanddone/pull/296

Comment 4

[u279076]

Okay thanks. Let me know when it's ready and I'll retest.

Comment 5

[Bob Silverberg [:bsilverberg]]

Commits pushed to master at https://github.com/mozilla/oneanddone

https://github.com/mozilla/oneanddone/commit/6dbf2f91c1476d8e2f911f4ccbf03d9bdd033ccd
Fixes Bug 1207329 - Cannot use markdown syntax to linkify text

https://github.com/mozilla/oneanddone/commit/8c61eb1d18bcdd8e8d2c44dccb4659b8052acda6
Merge pull request #296 from bobsilverberg/fix_linkify

Fixes Bug 1207329 - Cannot use markdown syntax to linkify text

Comment 6

[u279076]

How long will this take to propagate to the server? I'm still seeing this issue.

Comment 7

[Bob Silverberg [:bsilverberg]]

Rebecca is testing it on dev and then I will push it to prod. I'll update the bug when that happens.

Comment 8

[Rebecca Billings [:rbillings]]

Verified on dev links work with updated markdown - bit.ly as well as regular URLs.

Comment 9

[Bob Silverberg [:bsilverberg]]

Thanks Rebecca. I have pushed the fix to staging and production as well.

Comment 10

[Rebecca Billings [:rbillings]]

Verified on prod, including https://oneanddone.mozilla.org/en-US/tasks/143/ displays correctly.