1207363 - Use Array.includes in mail/ instead of indexOf != / == -1

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=279ea57731dc

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/0c9f89670ac8

Comment 2

[aleth [:aleth]]

Did you do this with a script? If yes, can we run it on im/ and chat/ too? ;)

Comment 3

[Jorg K (CEST = GMT+2)]

Just out of interest: What's the practical value of this?
According to this
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
it's experimental and was introduced at gecko43.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From bug 1208849 comment 0:
> [...] I do this for relaxing and looking at code to learn and spot other bugs (found bug 1207364 that way).

> According to this
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> Global_Objects/Array/includes
> it's experimental and was introduced at gecko43.
It landed much earlier but was only enabled in Nightly. It does what String.prototype.includes does (available since Gecko 40) and the goal was to assign both methods the same name. So there was time for adaption to get tracktion and testing when it was enabled on Nightly.

Comment 5

[aleth [:aleth]]

(In reply to Jorg K (GMT+2) from comment #3)
> Just out of interest: What's the practical value of this?

It makes the code more readable, imho.