1207554 - The line between the panels and the content is shorter than the width of the screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Flaviu Cos]

Attachment: panels underline.png

Environment: 
Device: Lenovo Yoga Tab 10 (Android 4.4.2);
Build: Nightly 44.0a1 (2015-09-23);

Steps to reproduce:
1. Launch fennec;
2. Observe the panels from about:home.

Expected result:
The line that separates the content form the panels is as wide as the screen.

Actual result:
The line between the panels and the content is shorter than the width of the screen.

Notes:
Please check the attached screenshot.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sebastian, easy fix (match_parent?) or mentorable?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

That's interesting. I fixed something like this in bug 1186841 before. I'll have a look.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1207554 - TabMenuStrip: Fill viewport. r?mcomella

Bug 1207554 - TabMenuStrip: Fill viewport. r?mcomella

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #1)
> easy fix (match_parent?)

Almost! TabMenuStripLayout is already set to match_parent but the enclosing HorizontalScrollView (TabMenuStrip) ignores it unless setFillViewport(true) is called.

Comment 5

[Chenxia Liu [:liuche]]

Ahahha I ran into this bug too while trying to figure out how to only have two title items in the TabMenuStrip for the Firstrun, and ended up with the same fix :)

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8665415 [details]
MozReview Request: Bug 1207554 - TabMenuStrip: Fill viewport. r?mcomella

https://reviewboard.mozilla.org/r/20239/#review18251

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1e262cfbcda2

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Chenxia Liu [:liuche] from comment #5)
> Ahahha I ran into this bug too while trying to figure out how to only have
> two title items in the TabMenuStrip for the Firstrun, and ended up with the
> same fix :)

Heh. Thanks for pushing the patch! :)

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e262cfbcda2

Comment 10

[Flaviu Cos]

Verified as fixed in build 44.0a1 2015-09-29;
Device: Asus Transformer Pad (Android 4.2.1).