1207641 - Don't hide australis menu (≡) after clicking "Move to Toolbar" in context menu.

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[arni2033]

Attachment: screenshot - Don't hide australis menu (≡) after clicking 'Move to Toolbar' in context menu.png

STR:   (Win7_64, Nightly 44, 32bit, ID 20150922030204, new profile, safe mode)
1. Click (≡), hover mouse over any button in that menu, right-click on that button.
2. Click "Move to Toolbar" menuitem in context menu.

RESULT:
The chosen button was moved to toolbar, and menu collapsed

EXPECTATIONS:
The menu should stay visible, because user may want to continue customizing. If I, let say, need to move 3 items to toolbar - I have to open menu 3 times OR enter customize mode. I could perform the same operation faster if menu wouldn't hide every time an item was moved to toolbar

NOTE:
I first thought that it's an enhancement, but noticed that it's actually inconsistency, because if in Step 2 you choose menuitem by pressing Up and Down keys, and then pressing Enter, menu doesn't collapse

Comment 1

[:Gijs (he/him)]

(In reply to arni2033 from comment #0)
> I first thought that it's an enhancement, but noticed that it's actually
> inconsistency, because if in Step 2 you choose menuitem by pressing Up and
> Down keys, and then pressing Enter, menu doesn't collapse

That's a bug in the behaviour for Enter. The behaviour with the mouse is the one that's expected.

Philipp, thoughts?

Comment 2

[arni2033]

(In reply to :Gijs Kruitbosch from comment #1)
> The behaviour with the mouse is the one that's expected.
Woah?! I've changed my mind, I don't experience this bug anymore. Please don't "fix" Enter key   v_v

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Hm, I'm a bit confused, since I seem to get the exact opposite behavior:
- Selecting »Move to toolbar« with the mouse => Menu closes
- Selecting »Move to toolbar« with the keyboard => Menu stays open

Leaving the menu open seems like the better choice to me.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Oh, and I should really start paying more attention when reading bug, sorry.

Still, leaving the menu open makes sense to me, since it provides a bit more context (you see the item disappearing and re-appearing in the toolbar).

Comment 5

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN

Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN

Comment 6

[:Gijs (he/him)]

FWIW, I looked at the keypress case and I can't work out why we're not getting that. Even attaching system event listeners (or normal ones) to the actual menuitem got me nothing on OS X. No idea what's going on. If you have ideas, Matt, that'd be helpful. Not sure if this isn't causing wrong behaviour in other cases. Anyway, this fixes the issue at hand.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8673070 [details]
MozReview Request: Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN

https://reviewboard.mozilla.org/r/21841/#review19615

The diff LGTM

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7f6092c6c26d

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f6092c6c26d

Comment 10

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug with Firefox Nightly 44.0a1 (2015-09-23) (Build ID: 20150923030230) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 44.0b7 

Build ID: 20160107144911
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0

Comment 11

[Md. Ehsanul Hassan]

I have been reproduced this bug in Nightly 44.0a1 (2015-09-23) 

build ID:20150923030230
User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0 
on Windows 8.1(64bit)