Closed
Bug 1207840
Opened 9 years ago
Closed 9 years ago
Add special query param to session/destroy call made when user disconnects from sync
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
2.45 KB,
patch
|
zaach
:
review+
|
Details | Diff | Splinter Review |
We should record how often users explicitly choose to "disconnect" from FxA Sync.
Assignee | ||
Comment 1•9 years ago
|
||
hmmm - OTOH though, we already call the server on signout, so we should be able to get these stats directly from the server. I guess that would fail to capture disconnections while not connected to the network, but I'm not sure that's a real issue, and the desktop philosophy is "don't collect what a server already knows". rfkelly, what do you think?
Flags: needinfo?(rfkelly)
Comment 2•9 years ago
|
||
> we already call the server on signout
Is this the POST to /v1/session/destroy? We do track that, but I'm not sure if we can distinguish between is being called via the disconnect button in sync, versus a signout for other reasons via web content. Perhaps the distinction doesn't really matter anyway.
So yes, I think it would be reasonable to track this metric on the server. You could consider sending e.g. a `service=sync` query param on the request to make it a little easier to distinguish.
Flags: needinfo?(rfkelly)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Ryan Kelly [:rfkelly] from comment #2) > So yes, I think it would be reasonable to track this metric on the server. > You could consider sending e.g. a `service=sync` query param on the request > to make it a little easier to distinguish. Yeah, that sounds like a perfect compromise, thanks.
Summary: Add telemetry for "disconnect from sync" button → Add special query param to session/destroy call made when user disconnects from sync
Assignee | ||
Comment 4•9 years ago
|
||
This adds ?service=sync to the URL when calling /session/destroy. It's not ideal as the code is in services/fxaccounts, but assumes the service in question is "sync" (IOW, logging in and out of FxAccounts may log you in and out of more than just Sync in the future) - but chatting with rfkelly in IRC we agreed that's fine for now.
Attachment #8667098 -
Flags: review?(zack.carter)
Comment 5•9 years ago
|
||
Comment on attachment 8667098 [details] [diff] [review] 0001-Bug-1207840-add-service-sync-to-the-URL-used-when-di.patch Review of attachment 8667098 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8667098 -
Flags: review?(zack.carter) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2952be8a7652
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•