1207931 - RenderFrameParent::mBackgroundColor is unused

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicholas Nethercote [inactive]]

RenderFrameParent::mBackgroundColor can be set via SetBackgroundColor(), but
the value is never read. So that means TabParent::RecvSetBackgroundColor() is a
no-op.

billm, is this expected? It seems weird to me. Though maybe this message
doesn't matter and can be excised on both the child and the parent sides.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: RenderFrameParent::mBackgroundColor is unused

Patch demonstrating the situation.

Comment 2

[Andrew McCreight [:mccr8]]

That's really more of a layout question than an IPC one.

Comment 3

[Andrew McCreight [:mccr8]]

It looks like the use of the variable was added in bug 694706 and removed in bug 1056427. Just a bit of dead code that was missed. So I think it is okay to remove the message.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Yeah, I think we can get rid of this entirely.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Remove no-longer-needed SetBackgroundColor IPC message

This seems to work.

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8665743 [details] [diff] [review]
Remove no-longer-needed SetBackgroundColor IPC message

Review of attachment 8665743 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsPresShell.cpp
@@ -5292,5 @@
>    // color we actually draw.
>    if (!FrameConstructor()->GetRootElementFrame()) {
>      mCanvasBackgroundColor = GetDefaultBackgroundColorToDraw();
>    }
> -  if (XRE_IsContentProcess() && mPresContext->IsRoot()) {

Nice. This is the code that was fixed in bug 1199534 because it was spamming messages constantly. Turns out it wasn't needed at all!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22e54267e6c9

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22e54267e6c9