1208045 - Firefox hangs when closing WebIDE

Status: RESOLVED WONTFIX

(DevTools Graveyard :: WebIDE, defect)

Description

[Marco Castelluccio [:marco]]

When I close WebIDE, Firefox hangs. GNOME shows a dialog prompting me to close Firefox because it isn't responding.

After a while, when WebIDE gets closed, I can use Firefox again.

I can consistently reproduce this bug.

P.S.: I see another hang, shorter, when I resize the WebIDE window.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: x_1a9D2e.7z

Here's a profile.

Comment 2

[Marco Castelluccio [:marco]]

I'm seeing ~28% of the time spent in the *sync* function in http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/service.js

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I'm not sure what to do with the .bin file in that profile attachment. If you set browser.dom.window.dump.enabled=true and services.sync.log.appender.dump="Trace", you should see Sync messages spewed to the console which will probably offer some clues - the fact it is 100% reproducible surprises me. Could you please try the above prefs and capture the output?

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Mark Hammond [:markh] from comment #3)
> I'm not sure what to do with the .bin file in that profile attachment.

You can upload it here to see the profile:
http://people.mozilla.org/~bgirard/cleopatra/

> If you set browser.dom.window.dump.enabled=true and
> services.sync.log.appender.dump="Trace", you should see Sync messages spewed
> to the console which will probably offer some clues - the fact it is 100%
> reproducible surprises me. Could you please try the above prefs and capture
> the output?

I will try this tomorrow.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

That profile is showing we are indeed uploading history records as part of a Sync. I *hope* this was fixed in bug 1195603 (which landed in 43) but the info I asked for above should be able to tell me either way.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mark Hammond [:markh] from comment #5)
> I *hope* this was fixed in bug 1195603 (which landed in 43)

Bugger - it looks like this was reported against 44, so apparently not :(

Comment 7

[Marco Castelluccio [:marco]]

Attachment: v7WEtcTN.7z

This second profile isn't related to Sync.
The common function between the two profiles is "PollWrapper" (in this second profile, > 60%).

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Marco, it sounds like this isn't related to Sync, so it sounds like we should put it back into the WebIDE category until we have more ideas?

Comment 9

[Marco Castelluccio [:marco]]

Yes, totally agree.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Marco, can you share the source of the project you have open in WebIDE?

Does it have a lot of files?

It looks like we may be spending a lot of clearing out the file tree, so we should optimize that if true.

Comment 11

[Marco Castelluccio [:marco]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #10)
> Marco, can you share the source of the project you have open in WebIDE?
> 
> Does it have a lot of files?
> 
> It looks like we may be spending a lot of clearing out the file tree, so we
> should optimize that if true.

This is likely the culprit. I've removed the projects from the list and now it doesn't hang anymore.
To reproduce again, I just need to re-add a directory with a lot of files.

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Marco Castelluccio [:marco] from comment #11)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #10)
> > Marco, can you share the source of the project you have open in WebIDE?
> > 
> > Does it have a lot of files?
> > 
> > It looks like we may be spending a lot of clearing out the file tree, so we
> > should optimize that if true.
> 
> This is likely the culprit. I've removed the projects from the list and now
> it doesn't hang anymore.
> To reproduce again, I just need to re-add a directory with a lot of files.

Are you able to mention the projects you had?  This would help me do a meaningful perf comparison with what you're seeing.

Comment 13

[Marco Castelluccio [:marco]]

I had a folder containing three subfolders: https://github.com/marco-c/watchy, https://github.com/marco-c/watchy/tree/gh-pages, https://github.com/mozilla/high-fidelity.

Comment 14

[Julian Descottes [:jdescottes]]

WebIDE triage. Filter on TRIAGE-JD201705

This is related app development in WebIDE, which is going to be removed. Closing as wontfix.