1208877 - [cs] Update Wikipedia searchplugin in SeaMonkey

Status: RESOLVED FIXED

(Mozilla Localizations :: cs / Czech, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

For Firefox <SearchForm> is missing.
Thunderbird has only one icon (compared to three in Firefox).
SeaMonkey has wrong icon (and one only), <Url template> and <SearchForm>.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ] from comment #0)
> For Firefox <SearchForm> is missing.
This needs to be fixed. I suggest to take care of it with the rest of Firefox in bug 1208872.

> Thunderbird has only one icon (compared to three in Firefox).
This doesn't need to be fixed. Only Firefox for Desktop has those extra images, and to be honest I'm pretty sure they're not used and we'll need to get rid of them soon.

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: bug1208877.patch

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8707918 [details] [diff] [review]
bug1208877.patch

Review of attachment 8707918 [details] [diff] [review]:
-----------------------------------------------------------------

That's an r- for the /browser part, but it's my fault (I should have double checked the actual XML before adding comment 1).

On Firefox desktop you can drop <searchform> if it uses the same URL as the actual search. So, instead of adding an explicit <searchform> element, you add an attribute to it (rel="searchform")
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/file/tip/browser/searchplugins/wikipedia-cz.xml#l17

The current Wikipedia searchplugin for desktop is correct, update happened in bug 1069123
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/c3513adce77a

Not sure if the same mechanism can be used in SeaMonkey.

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you. I also noticed now, that SM searchplugin icon is not wrong, only different but the same as in en-US. So just old URLs there.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: bug1208877.patch (v2)

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Thank you for the review.

https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/7e09e02c207f