Closed
Bug 1209204
Opened 9 years ago
Closed 9 years ago
Change Device Name button keeps focus outline even after pressing cancel on Mac
Categories
(Firefox :: Sync, defect)
Tracking
()
RESOLVED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: rfeeley, Assigned: markh)
References
Details
Attachments
(3 files)
nightly-mac.gif
See Mac example attached. Windows is fine.
|
Reporter | |
Comment 1•9 years ago
|
||
Windows version that doesn't suffer the blue halo of death.
|
Assignee | |
Comment 2•9 years ago
|
||
This was supposed to be fixed as part of bug 1194032 with the code at https://dxr.mozilla.org/mozilla-central/rev/acdb22976ff86539dc10413c5f366e1fb429a680/browser/components/preferences/in-content/sync.js#238 added specifically for this.
Blocks: 1194032
Flags: firefox-backlog+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Matt, we discussed this briefly on IRC. Instead of explicitly choosing the control to focus, this patch allows the focus manager to select it using whatever heuristics it uses. On the mac this causes one of the inline links to get focus instead of the button (ie, the same thing that gets focus if you press "tab" while in that "computer name" box.
|
||
Updated•9 years ago
|
Attachment #8683969 -
Flags: review?(MattN+bmo) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/db44f45662a8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in
before you can comment on or make changes to this bug.
Description
•