1209401 - Don't use preprocessor forced includes for API keys in nsURLFormatter.js

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't use preprocessor forced includes for API keys in nsURLFormatter.js

I think this is the only use of the -I option to preprocessor.py in the tree. I'll do a try build to see if we can just remove that option, which I always found confusing, since it doesn't match the C preprocessor at all.

Comment 2

[Mike Hommey [:glandium]]

Unsurprisingly, I was wrong about -I not being used elsewhere:
https://dxr.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8/toolkit/locales/Makefile.in#5

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8667107 [details] [diff] [review]
Don't use preprocessor forced includes for API keys in nsURLFormatter.js

Review of attachment 8667107 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0eedb958866d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0eedb958866d