1209792 - [New Homescreen] Specific bookmarks will be invisible and non functional after switching to the New Home Screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat_20150929_1606.txt

Description:
Certain homescreen bookmarks will be invisible and non-functional on the New Homescreen. Neither the icon nor the app name will be visible, but there will still be an empty space left for the bookmark in the icon grid.  Tapping the empty space of the icon will not launch the app, but holding and moving the empty space will rearrange other icons on the home screen as if the user were moving the bookmark.

I have only seen this issue with bookmarks that prompt the "An application is available for this web site." message when the site is added to the home screen. (Specifically Pinterest and Tumblr.  I'm not aware of which other websites do this).

Note: This occurs if the bookmark is added before or after changing to the New Home Screen

Repro Steps:
1) Update a Aries to 20150929110451
2) Navigate to Settings > Home Screens and change the device to the New Home Screen.
3) Open the browser and navigate to www.pinterest.com (Or www.tumblr.com)
4) Select 'Add Link to Home screen' and select 'Done' (Don't install the app, just add the bookmark)
5) On the Home Screen, move any app icon to the bottom of the screen, note that there is a blank space between the last and second to last icon.
6) Navigate to Settings > Home Screens and change back to Default Home Screen. Note that the Pinterest bookmark properly present

Actual:
The bookmark is not present on the New Home Screen.  A non-functional blank space is present instead.

Expected:
The bookmark is properly present on the New Home Screen

Environmental Variables:
Device: Aries 2.5
Build ID: 20150929110451
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: Logcat, Video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.5 builds.
The Pinterest bookmark is not present on the New Home Screen.  A non-functional blank space is present instead.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

The New Home Screen is not present in Flame 2.2 builds.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1209792-new-homescreen-bookmarks-with-manifests > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8667937 [details] [review]
[gaia] Cwiiis:bug1209792-new-homescreen-bookmarks-with-manifests > mozilla-b2g:master

LGTM!

Comment 4

[Chris Lord [:cwiiis]]

Thanks, merged: https://github.com/mozilla-b2g/gaia/commit/49a75c53b3119cf73f1dcec2926fe4a8ebde9da9

Comment 5

[Sxean Lee-David [:sxean]]

No Repro per builds: 
Environmental Variables:
Device: Aries 2.5
BuildID: 20151005111147
Gaia: b994cedaa7ef9bfadcbe841601d9dc8d2e5379f9
Gecko: 45f01961ecd0ad9a45067f3e08bfb92539042eeb
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

AND,

Device: Flame 2.5
BuildID: 20151005030238
Gaia: b994cedaa7ef9bfadcbe841601d9dc8d2e5379f9
Gecko: b56aeea0c4701677ffda6417183caa60d2a6a4a7
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0


Result:
When adding a URL link to the Default Home screen, then switching to NEW Home screen, or vice-versa,
URL link is present on both Home screen types.