1209865 - Show the marks from |performance.mark| on Gecko profile

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Currently we need to use |console.time| or other ways to show the specific marks on the profiling result, which is not intuitive enough as |performance.mark|. We should implement this.

Comment 1

[Ting-Yu Chou [:ting] (away)]

Attachment: patch v1

Comment 2

[Ting-Yu Chou [:ting] (away)]

Thanks for prompt reivew.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ade98e422727

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c3e1c2fc632

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We have also Bug 1170314, console.timeStamp.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

If this provides similar functionality, Bug 1170314 could be perhaps backed out, since performance.mark is perhaps a tiny bit less odd place to have this kind of side effects.

Comment 6

[Ting-Yu Chou [:ting] (away)]

Is it OK to ask sheriff to backout bug 1170314, or I should make a patch somewhere?

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c3e1c2fc632

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Could you still verify with BenWa that the functionality is the same, and if it is, then backing out that other patch/bug should be fine.

Comment 9

[Ting-Yu Chou [:ting] (away)]

The cset on m-c and m-i are empty, seems something wrong with Pulsebot?

Comment 10

[Ting-Yu Chou [:ting] (away)]

(In reply to Olli Pettay [:smaug] from comment #8)
> Could you still verify with BenWa that the functionality is the same, and if
> it is, then backing out that other patch/bug should be fine.

It should be the same as both go to PROFILER_MARKER().

BenWa, could you confirm that bug 1170314 has the same functionality (add a marker to gecko profiler) with the patch here? Thank you.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/561ebe842566

Comment 12

[Carsten Book [:Tomcat]]

landed again, seems qimport failed somehow before (no idea why)

Comment 13

[Benoit Girard (:BenWa)]

It looks like it is indeed duplicate. I'd say we should back bug 1170314 out.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/561ebe842566