1209906 - Remove IdSchema validation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

Normally, FxSync id's are 9-character (12-byte) URL-safe Base64 strings, but in the bookmarks collection, there are some special id's (currently there are four, 'menu', 'toolbar', 'mobile', and 'unfiled').

The FxSyncIdSchema in SyncEngine should be configurable to deal with this.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1209906-special-fxsync-ids > mozilla-b2g:master

Comment 2

[Michiel de Jong [:michielbdejong]]

(In reply to Michiel de Jong [:michielbdejong] from comment #0)
> Normally, FxSync id's are 9-character (12-byte) URL-safe Base64 strings, but
> in the bookmarks collection, there are some special id's (currently there
> are four, 'menu', 'toolbar', 'mobile', and 'unfiled').
> 
> The FxSyncIdSchema in SyncEngine should be configurable to deal with this.

The full list is actually:
        public static final String MOBILE_FOLDER_GUID = "mobile";
        public static final String PLACES_FOLDER_GUID = "places";
        public static final String MENU_FOLDER_GUID = "menu";
        public static final String TAGS_FOLDER_GUID = "tags";
        public static final String TOOLBAR_FOLDER_GUID = "toolbar";
        public static final String UNFILED_FOLDER_GUID = "unfiled";
        public static final String FAKE_DESKTOP_FOLDER_GUID = "desktop";
        public static final String PINNED_FOLDER_GUID = "pinned";

(from mobile/android/base/db/BrowserContract.java)

Comment 3

[Sean Lee [:seanlee][:weilonge]]

(In reply to Michiel de Jong [:michielbdejong] from comment #2)
> (In reply to Michiel de Jong [:michielbdejong] from comment #0)
> > Normally, FxSync id's are 9-character (12-byte) URL-safe Base64 strings, but
> > in the bookmarks collection, there are some special id's (currently there
> > are four, 'menu', 'toolbar', 'mobile', and 'unfiled').
> > 
> > The FxSyncIdSchema in SyncEngine should be configurable to deal with this.
> 
> The full list is actually:
>         public static final String MOBILE_FOLDER_GUID = "mobile";
>         public static final String PLACES_FOLDER_GUID = "places";
>         public static final String MENU_FOLDER_GUID = "menu";
>         public static final String TAGS_FOLDER_GUID = "tags";
>         public static final String TOOLBAR_FOLDER_GUID = "toolbar";
>         public static final String UNFILED_FOLDER_GUID = "unfiled";
>         public static final String FAKE_DESKTOP_FOLDER_GUID = "desktop";
>         public static final String PINNED_FOLDER_GUID = "pinned";
> 
> (from mobile/android/base/db/BrowserContract.java)

I am thinking if FxSync adds a new special ID before we realize that and fix it, SyncEngine will throw errors for the invalid/unknown ID.
When FxSync feature is in FxOS, that will be an issue that we have to catch up the changes of these special IDs and impact FxSync users in FxOS.

This issue lets me consider the necessary of validating ID.

Comment 4

[Michiel de Jong [:michielbdejong]]

OK, I'll remove IdSchema validation altogether. Maybe just check that it's a String.

Comment 5

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8668426 [details] [review]
[gaia] michielbdejong:1209906-special-fxsync-ids > mozilla-b2g:master

Sorry, wrong branch.

Comment 6

[Michiel de Jong [:michielbdejong]]

Attachment: [gaia] michielbdejong:1209906-remove-IdSchema-checks > mozilla-b2g:master

Manually creating attachment (hope this works)

Comment 7

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8668888 [details] [review]
[gaia] michielbdejong:1209906-remove-IdSchema-checks > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/pull/32197

Comment 8

[Michiel de Jong [:michielbdejong]]

Attachment: [gaia] michielbdejong:1209906-remove-IdSchema-checks > mozilla-b2g:master

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/944b337e84685a15e75c370b144cb094c0491604