Closed
Bug 1209920
Opened 9 years ago
Closed 9 years ago
Drop support for <MozParam condition="defaultEngine"
Categories
(Firefox :: Search, defect, P3)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
15.44 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
This feature was used (afaik) by the Google search plugin until bug 1103216. When looking at the code of the _isDefaultEngine method, I noticed that it is definitely broken since we implemented region-defaults (bug 1175218), and nobody complained... MXR tells me the only references to this in mozilla-central are in tests. The only references in l10n-central are the Google plugins for SeaMonkey in the Japanese locales (bug 1103970 has probably not been ported to SeaMonkey). I double checked with mconnor if this was OK to remove or if we should fix it. He said this is currently not used but potentially valuable in the future. However, his final words were "Let's kill it for now, we can always add it back in the future if it's needed."
Attachment #8667838 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8667838 -
Flags: review?(adw) → review+
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81ed15cfdbfa
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•