1210059 - Add a 'Learn More' link to the private browsing empty view that links to a SUMO article

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stephan Leroux [:sleroux]]

On Android, we have a 'Learn more...' button that takes the user to a SUMO article explaining what private browsing is. This bug is to add the same link for iOS.

Comment 1

[Stephan Leroux [:sleroux]]

Roland, someone mentioned we have a SUMO article that we can link to. Does this need any changes for iOS?

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

hi stephan: great question, my guess is we will need a separate article for private browsing for iOS since it would be too hard to do conditional markup for android and ios (and we don't yet have conditional markup i.e. "showfor" for ios, that will come in 2016 i think)

joni: am i right? if so please create a stub article that stephan et al can link to this week please.

(needinfo-ing our fantastic content editor joni savage who writes all english articles for sumo for firefox desktop, ios, android and Firefox os)

Comment 3

[Stephan Leroux [:sleroux]]

How do we want this to look? Darker gray, centered below the empty private tabs tray text?

Comment 4

[Darrin Henein [:darrin]]

Attachment: Screen Shot 2015-10-02 at 2.53.48 PM.png

Same text color as the selected text highlight on the URL bar in private mode (rgb 120/120/165), 15pt system font medium.

Comment 5

[Joni Chan]

Hi, Holly also asked for a private browsing article for iOS, so we've set up a placeholder. 

Here's the in-product link you can use: https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/private-browsing-ios

Just replace the %Version%/%OS%/%Locale% tuple. It will automatically redirect to the SUMO page.

Comment 6

[Stephan Leroux [:sleroux]]

Does this URL look right for US/English locale? Just want to make sure the formats line up.

https://support.mozilla.org/1/mobile/1.1/iOS/en_US/private-browsing-ios

Comment 7

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1122

Comment 8

[Darrin Henein [:darrin]]

Comment on attachment 8669716 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1122

Nice! Can we include a down state so we're not tracking these down later (I thought iOS had built in ones for buttons?)... basically a slightly transparent version of the text. + with that nit.

Comment 9

[Joni Chan]

(In reply to Stephan Leroux [:sleroux] from comment #6)
> Does this URL look right for US/English locale? Just want to make sure the
> formats line up.
> 
> https://support.mozilla.org/1/mobile/1.1/iOS/en_US/private-browsing-ios

Hi Stephan, it's close. We use "en-us" for English (US) locale.

Comment 10

[Stephan Leroux [:sleroux]]

Thanks! I've added a follow up commit to use the language identifier instead of the locale one:

https://github.com/mozilla/firefox-ios/commit/1b2ca44d25bbc76e1faaf547037f9490739608cc

Comment 11

[Stephan Leroux [:sleroux]]

Merged