1210246 - enter_bug.cgi?: bugzilla.mozilla.org help link is busted

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

I'm using the "Dusk" skin on bugzilla.m.o, if it matters. The "help" link in the header and footer links is broken; it sends me to https://bmo.readthedocs.org/en/latest/bugreports.html which shows me an ascii-art 404 page.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I feel like this is something pretty important to fix for new contributors to mozilla and probably trivial to boot, so ni? to :glob to bring some attention to it. I'm seeing that depending on what bugzilla page I'm on the link points to something different (for example, while viewing this bug the link points to https://bmo.readthedocs.org/en/latest/bug_page.html). Even just changing it to always point to https://bmo.readthedocs.org/en/latest/ would be better than 404s.

Comment 2

[:glob ✱]

this only impacts the dusk skin (which isn't the default) and only on the enter-bug page.
i'll push a quick fix, but it's far from "pretty important" :)

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b7261d4..6cbec76  master -> master

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Byron Jones ‹:glob› from comment #2)
> this only impacts the dusk skin (which isn't the default) and only on the
> enter-bug page.
> i'll push a quick fix, but it's far from "pretty important" :)

Thanks for pushing the fix but I am definitely seeing it on more than the enter-bug page. I see it on search results and bug viewing pages too, for example.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Ah, when I change to the default skin there isn't even a help link on most pages.

Comment 6

[Rainer Bielefeld]

This one is definitively not fixed completely.

This page shown in "Classic" skin has a "Help" hyperlink in the page heading left from "log out":
...| Product Dashboard | Preferences | Administration | Help | Log out 

And this link leads to bmo.readthedocs.org/en/latest/ as reported.

May be we need to split this one into several Bugs related to skin, page and whatever else?

Comment 7

[:glob ✱]

please file a new bug for new issues.

Comment 8

[Rainer Bielefeld]

If we would be in real life here, I would have expected that you check whether the "quick fix" is incomplete or whether we really have a completely different here, and if it's something different YOU might have opened a new bug? 
But I know, the Mozilla spirit ...

I opened a NEW bug "Bug 1236799 - Classic Skin: Help link in page heading leads to empty page (error)" for Classic Theme problem found with test in my Comment 6, because you limited this one to "Dusk" skin (although I think that that is superfluous)

But Back to this one.
I did the same test as per Comment 6 with DUSK skin, Help-link still leads to empty page (error message).

So we have some questions here
a) for what Help link on what page(s) is the fix you pushed?
b) Is the fix already active in Bugzilla or when will it appear
c) With what proceeding can the fix be tested?

Comment 9

[:glob ✱]

please don't reopen bugs that have already been marked as fixed; always file a new bug.  this allows us to correctly track follow-up changes.

thanks!

> a) for what Help link on what page(s) is the fix you pushed?

enter_bug.cgi

> b) Is the fix already active in Bugzilla or when will it appear

yes; this was fixed 3 months ago

Comment 10

[Rainer Bielefeld]

(In reply to Byron Jones ‹:glob› from comment #9)
Please simply leave a useful Summary so that it's clear what bug exactly has been fixed.

I tested BZ.M version 2015.12.22 with DUSK and Classic skin for "enter_bug.cgi?product=SeaMonkey": Help link leads to appropriate help contents <https://bmo.readthedocs.org/en/latest/using/filing.html>

BTW: You really expect that bugzilla.mozilla users will have to file separate bugs for any missing help link before someone will take action? My experience from tens of thousands of comments and bug reports in more than ten thousand different Bugzilla-bug-reports (other bug trackers not counted) in many projects seems to tell that there might be a more effective approach. Any chance to search Bugzilla UI source for Help links and try to find a pattern what allows to find wrong links without trial and error?

Comment 11

[:glob ✱]

(In reply to Rainer Bielefeld from comment #10)
> BTW: You really expect that bugzilla.mozilla users will have to file
> separate bugs for any missing help link before someone will take action?

no; i don't expect that nor is that what i asked for.

reopening a bug which is already marked as fixed is the problem.  when you do that it makes it very difficult to track ownership and resolution dates, especially in cases where a different person performs the follow up fixes.