1210566 - Message will say alarm is set for "0 minutes from now" when setting an alarm for less than a minute in the future in the clock app.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user sets an alarm to go off in less than a minute from the current time there will be a toast for the alarm that appears at the bottom of the screen that says "The alarm is set for 0 minutes from now"

Repro Steps:
1) Update a Aries to 20151001114357
2) Open the clock app
3) Create a new alarm
4) Set the alarm time for one minute in the future
5) Observe message that appears after setting the alarm

Actual:
The message says the alarm will go off in "0 minutes"

Expected:
It is expected that the alarm says less than a minute or shows the seconds.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20151001114357
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 2c1fb007137dcb68b1862a79553b53f1a34c99c3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: Screenshot, logcats

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

Attachment: 0 minutes

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20151001030229
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 096c0f407f8ba3ef7cfe4e0b831761993cac38b1
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
The message says the alarm will go off in "0 minutes"
------------------------------------
This issue DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 [Full Flash]
BuildID: 20151001032503
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: 5a8574453182
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The message says "less than a minute"

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1210566-clock-less-than-a-minute-from-now > mozilla-b2g:master

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8668710 [details] [review]
[gaia] zbraniecki:1210566-clock-less-than-a-minute-from-now > mozilla-b2g:master

Leftover from when I tried to format all numbers. Unfortunately we can't format numbers that go through L10n this way.

In L20n we just format number variables on output, so we'll get this working when Clock will switch to L20n.

For now, this patch fixes the problem.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/86fe0d5945d483891909c2c4fc9cb1da0b277fe4

Comment 6

[Marcus Cavanaugh [:mcav]]

Resolved per Comment 5.

Comment 7

[Adam Alldredge [:AdamA][Inactive]]

this issue is verified fixed in Aries 2.5 and Flame 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151008143352
Gaia: 4973f57cd8f9a62a95f783a24eac32da2bde99fc
Gecko: 1f4cf75c894862cf3634d6014d8de9c807a054a7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.5 [Full Flash]
BuildID: 20151006030203
Gaia: 60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gecko: 3edc8d4a1e198314f5d7ebd2967b85842beef602
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
The message says "less than a minute from now"

Comment 8

[Shally Li（leave from Mozilla）]

Per comment 7, clear verifyme.