Closed
Bug 1210611
Opened 9 years ago
Closed 9 years ago
Globally define MOZILLA_OFFICIAL
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox43 fixed, firefox44 fixed)
VERIFIED
FIXED
mozilla44
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(2 files, 1 obsolete file)
5.38 KB,
patch
|
Details | Diff | Splinter Review | |
5.33 KB,
patch
|
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
*grumble* *grumble* My fix for bug 1198525 didn't actually change anything. The contents of about:rights in Nightly and Aurora is still the unbranded flavor. The cause is that despite MOZILLA_OFFICIAL being used in various places, it's only explicitly pulled out of the global config in _those_ places for use as a #define. This wasn't being done in toolkit/content/jar.mn, and so the #ifdef MOZILLA_OFFICIAL there never actually works. :( This is kind of ridiculous, so I've changed it to be a global #define from autoconf, as opposed to being used piecemeal.
Assignee | ||
Comment 1•9 years ago
|
||
I did a build with "export MOZILLA_OFFICIAL=1" in my mozconfig to confirm this actually fixes about:rights.
Assignee: nobody → dolske
Attachment #8668709 -
Flags: review?(mh+mozilla)
Comment 2•9 years ago
|
||
Comment on attachment 8668709 [details] [diff] [review] Patch v.1 Review of attachment 8668709 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/app/moz.build @@ +28,5 @@ > FINAL_TARGET_FILES.defaults.profile += ['profile/prefs.js'] > > DEFINES['APP_VERSION'] = CONFIG['MOZ_APP_VERSION'] > > +for var in ('LIBXUL_SDK'): python can be confusing. This is equivalent to for var in 'LIBXUL_SDK', which will iterate over each letter in the string. The right format for a tuple with 1 element would be ('LIBXUL_SDK',). But since there is only one left, you might as well remove the loop.
Attachment #8668709 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Fixed broken loop.
Attachment #8668709 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8669184 -
Attachment is patch: true
Assignee | ||
Comment 5•9 years ago
|
||
Fix trivial merge conflict for Aurora. Approval Request Comment [Feature/regressing bug #]: incomplete fix from bug 1198525 [User impact if declined]: incorrect text in about:rights [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: low, this makes official Nightly and Aurora builds have the same text that we ship on Beta and Release. (Developer builds will be unchanged.) [String/UUID change made/needed]: n/a
Attachment #8669206 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3e53831ea3df
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment 7•9 years ago
|
||
Comment on attachment 8669206 [details] [diff] [review] Patch for aurora Useful looking! Fixes about:rights, for now. Let's uplift to aurora.
Attachment #8669206 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•9 years ago
|
||
Current Nightly now has the expected text, so looks like this finally fixed it.
Status: RESOLVED → VERIFIED
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0cd19a713a9b
status-firefox43:
--- → fixed
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•5 years ago
|
Target Milestone: Firefox 44 → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•