1211017 - When opening a toolbox targeting a worker / service worker, the title is `Debugger (null)`

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: debugger-toolbox-title.png

STR:

Enable devtools.debugger.workers
Open http://bgrins.github.io/devtools-demos/worker/webworker.html
Open debugger and click on one of the workers

A toolbox opens and the title is "Debugger (null)".  It should probably have the source name parenthesized (or nothing at all!).

See screenshot

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: toolbox-title.patch

WIP, needs a test

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Created attachment 8669242 [details]
> MozReview Request: Bug 1211017 - Show URL as the title in worker
> toolboxes;r=ejpbruel
> 
> Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

Notice that the getter for `name` on the target is already handling the isAddon case that the toolbox was previously trying to do: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/target.js#381.

Also, the new test is very simple but could be expanded soon as we need to test more related stuff.  And rather than testing the new experimental worker debugger listing UI within the debugger, it's using showToolbox directly so it also covers similar the behavior that's used by the upcoming about:debugging page.

Comment 4

[Brian Grinstead [:bgrins]]

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8104bc4da7a

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The Browser Content Toolbox has the same problem, not sure if this patch helps there or not, see bug 1145312.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> The Browser Content Toolbox has the same problem, not sure if this patch
> helps there or not, see bug 1145312.

Just checked and it doesn't, I'm guessing whatever target it is using needs to implement a `name` or `url` property.

Comment 7

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8669242 [details]
MozReview Request: Bug 1211017 - Show URL as the title in worker toolboxes;r=ejpbruel

https://reviewboard.mozilla.org/r/21165/#review19233

LGTM. Thanks for doing this Brian! This was another one of those papercuts that made me feel like the worker debugger is not production ready.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2ebf10394882

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ebf10394882