1211134 - Remove BrowserMigrator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It's no longer needed.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1211134_remove_browser_migrator > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8669310 [details] [review]
[gaia] KevinGrandon:bug_1211134_remove_browser_migrator > mozilla-b2g:master

We no longer need the bookmark migration as we only support upgrading to two versions at a time. Keeping AppMigrator for now though as it will help with home screen migration in the future.

Chris - since you've seen this code lately, or Kyle since you wrote this, wondering if either one of you could take a look. Thanks!

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8669310 [details] [review]
[gaia] KevinGrandon:bug_1211134_remove_browser_migrator > mozilla-b2g:master

This removal looks fine to me, but I really don't know enough about what it's doing/was intended for. If you're confident, I don't mind if you treat this as an r+, but otherwise might be worth waiting for Kyle.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8669310 [details] [review]
[gaia] KevinGrandon:bug_1211134_remove_browser_migrator > mozilla-b2g:master

Burn it all down.

Comment 5

[Kevin Grandon :kgrandon]

Thanks for the reviews!

In master: https://github.com/mozilla-b2g/gaia/commit/b994cedaa7ef9bfadcbe841601d9dc8d2e5379f9