1211397 - ClojureScript has no syntax highlight

Status: RESOLVED DUPLICATE of bug 1513608

(DevTools :: Source Editor, defect, P3)

Description

[Žilvinas]

Attachment: Screen Shot 2015-10-05 at 13.08.35.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151004004023

Steps to reproduce:

Went to website that uses ClojureScript and has source maps for it. For example: http://clojurescriptkoans.com/

Opened Dev Tools  -> Debugger and located any of .cljs type of files.


Actual results:

Did not see any syntax highlights for any of the ClojureScript files.


Expected results:

Should have syntax highlight colors, since CodeMirror supports them and afaik Debugger uses CodeMirror for syntax highlights.

Comment 1

[David Walsh :davidwalsh]

:gl, you helped implement :haxe, could you let me know if this is enable or help provide :clojurescript support?

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

clojurescript is currently not part of our codemirror bundle. I can add it in the next time we upgrade CodeMirror.

In the meantime, can you also figure out any outstanding modes that we should add and we can do that all at once in the next upgrade of CodeMirror.

Comment 3

[David Walsh :davidwalsh]

I just reviewed our issue list and Clojurescript is the last request at this time.

Comment 5

[finalfantasia]

Attachment: Bug-1211397-Include-CodeMirror-Clojure-mode-in-Webpack-bundle.patch

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9033061 [details] [diff] [review]
Bug-1211397-Include-CodeMirror-Clojure-mode-in-Webpack-bundle.patch

Review of attachment 9033061 [details] [diff] [review]:
-----------------------------------------------------------------

This requires a new webpack bundle as described in https://searchfox.org/mozilla-central/source/devtools/client/sourceeditor/README#12 unfortunately. I also know that the current webpack config is broken since the packages are now out of date so it's no longer trivial. I will carryover this patch in Bug 1513608 and mark this as a duplicate.

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 9033061 [details] [diff] [review]
Bug-1211397-Include-CodeMirror-Clojure-mode-in-Webpack-bundle.patch

Clearing review as per Comment 6