Closed Bug 1212 Opened 26 years ago Closed 25 years ago

Miscellaneous changes to include/glhist.h

Categories

(Core :: DOM: Core & HTML, defect, P2)

Sun
Solaris
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: tor, Assigned: gagan)

Details

This isn't strictly a netlib problem, but your library was the first
to trip over it and there didn't seem to be a more directly related
component.  Feel free to reasign to someone more appropriate.

include/glhist.h has a couple of enumerated typedefs in which the
enum name and typename are the same.  This patch changes them to
match the other declarations in the file, which use a leading underscore
for the enum name.

--- glhist.h-orig       Fri Oct 30 14:14:25 1998
+++ glhist.h    Fri Oct 30 14:17:59 1998
@@ -21,7 +21,7 @@

 #include "ntypes.h"

-typedef enum gh_SortColumn
+typedef enum _gh_SortColumn
 {
    eGH_NoSort = -1,
    eGH_NameSort,
@@ -50,7 +50,7 @@
     char *  pszName;
 }gh_HistEntryData;

-typedef enum gh_FilterOp
+typedef enum _gh_FilterOp
 {
    eGH_FOEquals,
    eGH_FOEqualsNot,
@@ -64,7 +64,7 @@
    eGH_FOHasNot
 }gh_FilterOp;

-typedef enum gh_FilterLogOp
+typedef enum _gh_FilterLogOp
 {
    eGH_FLOAnd,
    eGH_FLOOr
@@ -72,8 +72,8 @@

 typedef struct _gh_FilterCondition
 {
-   enum gh_SortColumn enCol;
-   enum gh_FilterOp   enOp;
+   gh_SortColumn enCol;
+   gh_FilterOp   enOp;

    union
    {
@@ -157,7 +157,7 @@
 // Context/Handle based functions to retrieve a pseudo cursor on the
 // Global History list (using a specified sort/index).
 */
-extern GHHANDLE        GH_GetContext( enum gh_SortColumn   enGHSort,
+extern GHHANDLE        GH_GetContext( gh_SortColumn        enGHSort,
                                       gh_Filter *          pFilter,
                                       GHISTORY_NOTIFYPROC  pfNotifyProc,
                                       GHURHANDLE
hUR,
Status: NEW → ASSIGNED
Assigned for now...
Component: NetLib → Content Model
Product: Mozilla → NGLayout
Setting all current Open/Normal to M4.
setting paulmac as QA contact for all gagan's bugs (sorry for the spam)
Target Milestone: M4 → M5
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
These changes have already been applied.
Status: RESOLVED → VERIFIED
marking verified since reporter marked fixed
Flags: in-testsuite-
Depends on: 1209559
No longer depends on: 1209559
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.