1212288 - Make ImageContainer::AllocateProducerID callable on all threads

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Kilik Kuo [:kikuo] (inactive)]

According to Bug 1194918 Comment 39, 40, 43, to make AllocateProducerID() callable on all threads can make it used more widely.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Not clear which component the bug should belong to ...

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Attachment: MozReview Request: Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r=roc.

Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r?roc

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8671155 [details]
MozReview Request: Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r=roc.

https://reviewboard.mozilla.org/r/21547/#review19369

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> Comment on attachment 8671155 [details]
> MozReview Request: Bug 1212288 - Make ImageContainer::AllocateProducerID
> callable on all threads; r?roc
> 
> https://reviewboard.mozilla.org/r/21547/#review19369

Thanks for review.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/21547/#review19371

::: gfx/layers/ImageContainer.cpp:676
(Diff revision 1)
> -static ImageContainer::ProducerID sProducerID = 0;
> +static Atomic<ImageContainer::ProducerID> sProducerID(0u);

Is the constructor of Atomic trivial enough for the compiler not to emit a static initializer?

Not sure if this guideline is still relevant?
https://developer.mozilla.org/en-US/docs/Mozilla/C%2B%2B_Portability_Guide#Don't_use_static_constructors

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

I'm not sure if the compiler bug mentioned in guideline still happens nowadays.
I can apply Construct on first use idiom here.

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8671155 [details]
MozReview Request: Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r=roc.

Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r=roc.
Construct the static variable on first use to avoid this potential issue mentioned here https://developer.mozilla.org/en-US/docs/Mozilla/C%2B%2B_Portability_Guide#Don%27t_use_static_constructors

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8671155 [details]
MozReview Request: Bug 1212288 - Make ImageContainer::AllocateProducerID callable on all threads; r=roc.

https://reviewboard.mozilla.org/r/21547/#review19373

Comment 9

[Kilik Kuo [:kikuo] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=895689c4e5ea
Don't know why the task queue for windows platform is getting so long ... but the results on all other platforms look just fine.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db193b0893a1

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0b33ab526a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d0b33ab526a