121246 - gtk2 has rendering bug in url bar, text fields

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Christopher Blizzard (:blizzard)]

The gtk2 port doesn't always draw text properly in the url bar and in text
fields.  I suspect it's a problem with the regions implementation.  Also, this
bug looks familiar.  I seem to think it has to do with the "single region" idea
or something.  I think that bryner might have found this bug in the old region
code.  Look there for clues.

Comment 1

[Christopher Blizzard (:blizzard)]

Fixed.  Easy patch:

Index: nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v
retrieving revision 1.22
diff -u -r1.22 nsWindow.cpp
--- nsWindow.cpp        28 Jan 2002 08:11:50 -0000      1.22
+++ nsWindow.cpp        29 Jan 2002 23:23:17 -0000
@@ -495,7 +495,7 @@
                           PRBool           aIsSynchronous)
 {
   GdkRegion *region = nsnull;
-  aRegion->GetNativeRegion((void *)region);
+  aRegion->GetNativeRegion((void *&)region);
 
   if (region) {
     GdkRectangle rect;