1212538 - [Accessibility] Change Add Contact screen reader label to Add Recipient.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Add contact label on compose screen needs to be changed to add recipient. Otherwise it is confusing.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

This entry (https://github.com/mozilla-b2g/gaia/blob/master/apps/email/locales/email.en-US.properties#L509) needs to change from compose-contact-add to compose-recipient-add along with it's value.

It is used in several places in apps/email/js/cards/compose.html so we need to update the name of the localization string as well.

Comment 2

[Aditya Srivastava]

Hey,
I would like to be assigned this bug. I have knowledge of HTML, CSS, Python and C but i'm new to open source, and might require some assistance. Should I be taking this up?

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

Comment 4

[Michael Kohler [:mkohler]]

Comment on attachment 8675289 [details] [review]
[gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/32527

Comment 5

[Michael Kohler [:mkohler]]

Setting assignment and review flag. This was done at the "Mozilla Day" today in Zurich, Switzerland. Great work, let's see if the reviewer agrees :)

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8675289 [details] [review]
[gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

Thank you very much for the pull request! There will be another change needed before this can be merged, due to how the localization process works:

If we change the meaning of a localization entry, then in order for the localization tools to notice the change, we should also change the key of the entry. I checked the French localization, and it seemed to go with a word that also meant "contact", and I expect other locales did the same. So we should change the key so they know the meaning is now slightly different.

Fortunately it is pretty easy: just find all the instances of 'compose-contact-add' used in apps/email/locales/email.en-US.properties and in the email app (of which there are three, all in apps/email/js/cards/compose.html), and change it to a new string that does not match an existing one in the email.en-US.properties. Perhaps 'compose-contact-add-recipient' since it makes it clearer, to match the string.

You can update the pull request to include that change, then flip the review? back to me again, and I can then re-review and hopefully merge the change.

Be sure the pull request just contains one commit, and not two commits. If you add another commit to the pull request, you can use `git rebase` to flatten it down to one commit.

Comment 7

[samu.agarwal]

Done, marked for review.

Comment 8

[James Burke [:jrburke]]

Comment on attachment 8675289 [details] [review]
[gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

This is very close to done, just one more change due to tools processes: in apps/email/locales/email.en-US.properties, the comment above the key needs to have its LOCALIZATION NOTE value in the parentheses also change to compose-contact-add-recipient.

The Localization tools for localizers require that format to properly associate the comment with that key.

After doing that change, flip review back to me, and it should be good to land!

Comment 9

[samu.agarwal]

Done, sorry it took some time, was in Prague.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Looks good to me, I added a small comment in the PR. I think James should be able to give the final go ahead after that

Comment 11

[James Burke [:jrburke]]

November 2nd is a string freeze date, so I would like to get this in before that date. samu.agarwal, if you do not think you will have a chance to fix the missing "n." in the pull request this week, let me know and we can look at a way for me to take what you have so far and update it for landing.

Comment 12

[samu.agarwal]

Sorry for the delay.

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

N(In reply to samu.agarwal from comment #12)
> Sorry for the delay.

No problem at all. Just see my last comment in the pull request where a comment ending for the string is cut off from 'screen.' to 'scree'. Feel free to ask for review from James after that. And thanks for sticking to it :)

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8675289 [details] [review]
[gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

This looks good now, flagging James for review. Thanks!

Comment 15

[James Burke [:jrburke]]

Comment on attachment 8675289 [details] [review]
[gaia] Swissnetizen:Fix-#1212538 > mozilla-b2g:master

Looks great, thank you for sticking with it! I will merge very soon into master, and place late-l10n flag on it (just a signal for the localization workflow).

Comment 16

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/d9bc8d8c6a70a7275753de1e64cee1b56f892992

from pull request:
https://github.com/mozilla-b2g/gaia/pull/32527

Thanks again for the contribution!